Skip to content

GH-34768: [C++][Gandiva] Accept LLVM 16 #34916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Apr 6, 2023
Merged

GH-34768: [C++][Gandiva] Accept LLVM 16 #34916

kou merged 1 commit into from
Apr 6, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Apr 6, 2023 •
edited by github-actions bot
Loading

Rationale for this change

LLVM 16 has been released.

What changes are included in this PR?

Accept LLVM 16.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou kou requested review from assignUser and raulcd as code owners April 6, 2023 00:23
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

@kou
Copy link
Member Author

kou commented Apr 6, 2023

+1

@kou kou merged commit 6530b01 into apache:main Apr 6, 2023
@kou kou deleted the cpp-llvm-16 branch April 6, 2023 05:36
@jorisvandenbossche jorisvandenbossche mentioned this pull request Apr 6, 2023
Merged
jorisvandenbossche added a commit that referenced this pull request Apr 6, 2023
@jorisvandenbossche
GH-34768: [C++][Gandiva] Remove LLVM<16 pin (#34922)
1c19650 
Small follow-up on #34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: #34768

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@ursabot
Copy link

ursabot commented Apr 6, 2023

Benchmark runs are scheduled for baseline = 8d8d21f and contender = 6530b01. 6530b01 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.26%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6530b019 ec2-t3-xlarge-us-east-2
[Failed] 6530b019 test-mac-arm
[Finished] 6530b019 ursa-i9-9960x
[Failed] 6530b019 ursa-thinkcentre-m75q
[Finished] 8d8d21ff ec2-t3-xlarge-us-east-2
[Failed] 8d8d21ff test-mac-arm
[Failed] 8d8d21ff ursa-i9-9960x
[Failed] 8d8d21ff ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou @liujiacheng777
apacheGH-34768: [C++][Gandiva] Accept LLVM 16 (apache#34916)
986f001 
### Rationale for this change

LLVM 16 has been released.

### What changes are included in this PR?

Accept LLVM 16.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34768

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@jorisvandenbossche @liujiacheng777
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
81966a0 
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-34768: [C++][Gandiva] Accept LLVM 16 (apache#34916)
e4f9393 
### Rationale for this change

LLVM 16 has been released.

### What changes are included in this PR?

Accept LLVM 16.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34768

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
f603e45 
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@dkav dkav mentioned this pull request Oct 27, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][Gandiva] Accept LLVM 16

2 participants

@kou @ursabot