Skip to content

GH-34768: [C++][Gandiva] Remove LLVM<16 pin #34922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 1 commit into from
Apr 6, 2023
Merged

GH-34768: [C++][Gandiva] Remove LLVM<16 pin #34922

jorisvandenbossche merged 1 commit into from
Apr 6, 2023

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 6, 2023 •
edited by github-actions bot
Loading

Small follow-up on #34916 to remove this temporary pin now LLVM 16 is accepted

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 6, 2023
@kou
Copy link
Member

kou commented Apr 6, 2023

Oh, sorry!

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Apr 6, 2023

No, that was only merged yesterday to get CI passing in a PR, normal that you missed that :) (I should have noted it on the issue)

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Apr 6, 2023

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Revision: ad42138

Submitted crossbow builds: ursacomputing/crossbow @ actions-f4d5413802

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

@jorisvandenbossche jorisvandenbossche merged commit 1c19650 into apache:main Apr 6, 2023
@jorisvandenbossche jorisvandenbossche deleted the remove-llvm-pin branch April 6, 2023 07:42
@ursabot
Copy link

ursabot commented Apr 7, 2023

Benchmark runs are scheduled for baseline = f6ecb21 and contender = 1c19650. 1c19650 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.77% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1c19650a ec2-t3-xlarge-us-east-2
[Failed] 1c19650a test-mac-arm
[Finished] 1c19650a ursa-i9-9960x
[Failed] 1c19650a ursa-thinkcentre-m75q
[Finished] f6ecb210 ec2-t3-xlarge-us-east-2
[Failed] f6ecb210 test-mac-arm
[Finished] f6ecb210 ursa-i9-9960x
[Failed] f6ecb210 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@jorisvandenbossche @liujiacheng777
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
81966a0 
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-34768: [C++][Gandiva] Remove LLVM<16 pin (apache#34922)
f603e45 
Small follow-up on apache#34916 to remove this temporary pin now LLVM 16 is accepted
* Closes: apache#34768

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][Gandiva] Accept LLVM 16

3 participants

@jorisvandenbossche @kou @ursabot