Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jan 28, 2019

Using this has little benefit with this class, and can cause tricky symbol linkage issues with some environments

@wesm
Copy link
Member Author

wesm commented Jan 28, 2019

LLVM apt is down

+sudo apt-add-repository -y 'deb http://llvm.org/apt/xenial/ llvm-toolchain-xenial-6.0 main'
+sudo apt-get update -qq
W: The repository 'http://llvm.org/apt/xenial llvm-toolchain-xenial-6.0 Release' does not have a Release file.
E: Failed to fetch https://llvm.org/apt/xenial/dists/llvm-toolchain-xenial-6.0/main/binary-amd64/Packages  Protocol "http" not supported or disabled in libcurl
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command "$TRAVIS_BUILD_DIR/ci/travis_install_clang_tools.sh" failed and exited with 100 during .

@kou
Copy link
Member

kou commented Jan 28, 2019

Could you also remove ARROW_EXPORT from tensor.{cc,h}?
Then we can remove ARROW_TEMPLATE_EXPORT too.

@kou
Copy link
Member

kou commented Jan 28, 2019

Or we can handle tensor as another issue.

wesm added 3 commits January 28, 2019 08:29
Change-Id: I06f0219754a01b24a8d89da0dcaafe0c4a9d9381
Change-Id: I77557ab4acee0776e54176eb1cd84eb887fa3dc6
Change-Id: Ib5b7489a8aa3143bcfa7f843f34f3ae7473f168d
@wesm wesm force-pushed the numeric-array-extern-template branch from d9c871f to a688a3e Compare January 28, 2019 14:29
@wesm
Copy link
Member Author

wesm commented Jan 28, 2019

I'm trying to remove those now

@wesm
Copy link
Member Author

wesm commented Jan 28, 2019

Looks like we can't completely remove ARROW_TEMPLATE_EXPORT yet since it's used in sparse_tensor.cc. I'm removing from NumericTensor<T> so we can look into SparseTensorImpl in a different patch

@wesm wesm changed the title ARROW-4399: [C++] Do not use extern template class with NumericArray<T> ARROW-4399: [C++] Do not use extern template class with NumericArray<T> and NumericTensor<T> Jan 28, 2019
Change-Id: Icefc4ad36e686fa5f4a65d9fd6ac02e9bd98427b
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wesm wesm closed this in 823dd43 Jan 28, 2019
@wesm wesm deleted the numeric-array-extern-template branch January 28, 2019 18:20
pitrou pushed a commit that referenced this pull request Jun 26, 2019
I'd like to stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl class so that it can be wrapped in Arrow GLib library on the mingw platform.

This is the continuation of #3509.

Author: Kenta Murata <mrkn@mrkn.jp>
Author: Wes McKinney <wesm+git@apache.org>

Closes #4670 from mrkn/stop_arrow_template_export_sparse_tensor_impl and squashes the following commits:

a24f78c <Wes McKinney> Code review feedback
819cce5 <Kenta Murata> Remove ARROW_EXPORT from SparseTensorImpl
5a6468f <Kenta Murata> Replace nullptr with NULLPTR
6a14b96 <Kenta Murata> Stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants