-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-4399: [C++] Do not use extern template class with NumericArray<T> and NumericTensor<T> #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LLVM apt is down |
|
Could you also remove |
|
Or we can handle tensor as another issue. |
Change-Id: I06f0219754a01b24a8d89da0dcaafe0c4a9d9381
Change-Id: I77557ab4acee0776e54176eb1cd84eb887fa3dc6
Change-Id: Ib5b7489a8aa3143bcfa7f843f34f3ae7473f168d
d9c871f to
a688a3e
Compare
|
I'm trying to remove those now |
|
Looks like we can't completely remove ARROW_TEMPLATE_EXPORT yet since it's used in sparse_tensor.cc. I'm removing from |
Change-Id: Icefc4ad36e686fa5f4a65d9fd6ac02e9bd98427b
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'd like to stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl class so that it can be wrapped in Arrow GLib library on the mingw platform. This is the continuation of #3509. Author: Kenta Murata <mrkn@mrkn.jp> Author: Wes McKinney <wesm+git@apache.org> Closes #4670 from mrkn/stop_arrow_template_export_sparse_tensor_impl and squashes the following commits: a24f78c <Wes McKinney> Code review feedback 819cce5 <Kenta Murata> Remove ARROW_EXPORT from SparseTensorImpl 5a6468f <Kenta Murata> Replace nullptr with NULLPTR 6a14b96 <Kenta Murata> Stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl
Using this has little benefit with this class, and can cause tricky symbol linkage issues with some environments