Skip to content

Conversation

@mrkn
Copy link
Member

@mrkn mrkn commented Jun 24, 2019

I'd like to stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl class so that it can be wrapped in Arrow GLib library on the mingw platform.

This is the continuation of #3509.

@wesm
Copy link
Member

wesm commented Jun 24, 2019

Looks OK to me except for the lint issue and linker failure on MSVC

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the principle.

@wesm
Copy link
Member

wesm commented Jun 26, 2019

Sorry to edit the branch, but since the code review comments were minor I went ahead and did them so we can get closer to release-readiness =)

@mrkn
Copy link
Member Author

mrkn commented Jun 26, 2019

@wesm No problem. Thank you very much!

@wesm
Copy link
Member

wesm commented Jun 26, 2019

We can't merge this until we address the Appveyor failure that's happening, I opened https://issues.apache.org/jira/browse/ARROW-5735

@pitrou pitrou force-pushed the stop_arrow_template_export_sparse_tensor_impl branch from 03bf578 to 6f98fac Compare June 26, 2019 12:15
@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

Rebased to integrate CI fixes.

@pitrou pitrou force-pushed the stop_arrow_template_export_sparse_tensor_impl branch from 6f98fac to a24f78c Compare June 26, 2019 12:18
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f3e1526). Click here to learn what that means.
The diff coverage is 41.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4670   +/-   ##
=========================================
  Coverage          ?   88.79%           
=========================================
  Files             ?      604           
  Lines             ?    75277           
  Branches          ?        0           
=========================================
  Hits              ?    66839           
  Misses            ?     8438           
  Partials          ?        0
Impacted Files Coverage Δ
cpp/src/arrow/sparse_tensor.h 89.18% <100%> (ø)
cpp/src/arrow/sparse_tensor.cc 73.8% <37.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e1526...a24f78c. Read the comment docs.

@pitrou pitrou closed this in 7586a65 Jun 26, 2019
@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

Thank you @mrkn !

@mrkn mrkn deleted the stop_arrow_template_export_sparse_tensor_impl branch June 27, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants