-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-5704: [C++] Stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-5704: [C++] Stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl #4670
Conversation
|
Looks OK to me except for the lint issue and linker failure on MSVC |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the principle.
|
Sorry to edit the branch, but since the code review comments were minor I went ahead and did them so we can get closer to release-readiness =) |
|
@wesm No problem. Thank you very much! |
|
We can't merge this until we address the Appveyor failure that's happening, I opened https://issues.apache.org/jira/browse/ARROW-5735 |
03bf578 to
6f98fac
Compare
|
Rebased to integrate CI fixes. |
6f98fac to
a24f78c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4670 +/- ##
=========================================
Coverage ? 88.79%
=========================================
Files ? 604
Lines ? 75277
Branches ? 0
=========================================
Hits ? 66839
Misses ? 8438
Partials ? 0
Continue to review full report at Codecov.
|
|
Thank you @mrkn ! |
I'd like to stop using ARROW_TEMPLATE_EXPORT for SparseTensorImpl class so that it can be wrapped in Arrow GLib library on the mingw platform.
This is the continuation of #3509.