-
Notifications
You must be signed in to change notification settings - Fork 4k
Arrow-582: [Java] Added JSON read/write support for Date, Time and TImestamp types #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow-582: [Java] Added JSON read/write support for Date, Time and TImestamp types #366
Conversation
…second types, added JSON test
|
Can you add tests for nanoseconds with integer values exceeding 2^32? |
|
sure |
|
@wesm , do you mean a |
|
@wesm @BryanCutler: I think the current TimeVector in java is milliseconds only |
|
@BryanCutler @julienledem do you want to coordinate to pick up the JSON support so we can get integration tests going? I will try to complete the C++ side sometime in the next week |
|
depends on: #407 |
|
It will be great to get this going! I should have some time in the next day or so to finish this up. @julienledem , does this also depend on ARROW-663 for additional vector value accessors? I think it should work now for 32-bit ints so maybe just get it working for TIME in milliseconds? |
|
@wesm would you still want the JSON read/write test from here? It doesn't look like the other PR had any |
|
I think it's in there -- the integration tests pass |
|
Not the integration tests, just on the Java side that test the Java JSON reader/writer are working java/vector/src/test/java/org/apache/arrow/vector/file/json/TestJSONFile.java https://github.com/apache/arrow/pull/366/files#diff-3166d7551b45955e3608b1a9deb0a13cR123 |
|
Ah sorry, I misread. Can you submit a rebased patch with the unit tests, that would be great. Much obliged |
|
sure, just made #495 |
…and Date types, and integration tests closes apache#366 Author: Leif Walsh <leif.walsh@gmail.com> Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#475 from leifwalsh/feature/java-date-time-types and squashes the following commits: 2e2a4cf [Leif Walsh] ARROW-729: [Java] removed Joda DateTime getters from Date* and Time* types 47f83a8 [Wes McKinney] Integration tests for all date and time combinations 6e86422 [Wes McKinney] ARROW-733: [C++/Python] Rename FixedWidthBinary to FixedSizeBinary for consistency with FixedSizeList 2dca474 [Leif Walsh] ARROW-729: [Java] Added units for date/time types
Modified
JsonFileReaderandJsonFileWriterto support Date and Time types. Date is written out as a Java Long and Time is written as a Java Integer.Added new unit test to verify read/write of JSON for Date, Time and Timestamp with milliseconds types.