ARROW-673: [Java] Support additional Time metadata #407
+10
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
reviewed
Mar 20, 2017
| @Override public MinorType visit(Time type) { | ||
| if (type.getUnit() != TimeUnit.MILLISECOND || type.getBitWidth() != 32) { | ||
| throw new IllegalArgumentException("Only milliseconds on 32 bits supported for now: " + type); | ||
| } |
Member
There was a problem hiding this comment.
Will you need to do something like what was done with timestamps for multiple unit support?
Member
Author
There was a problem hiding this comment.
Yes. I was thinking of doing it as a follow up. I think we need to change a little bit the notion of MinorType to avoid generating too many vector classes.
Member
|
LGTM |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
I will fix the underlying issue in Arrow but this fixes the issue so we can get a 1.3.1 release out soon. Author: Korn, Uwe <Uwe.Korn@blue-yonder.com> Closes apache#407 from xhochy/PARQUET-1121 and squashes the following commits: 85223b9 [Korn, Uwe] PARQUET-1121: Handle Dictionary[Null] arrays on writing Arrow tables Change-Id: I494817d655d9031b4d6a1ea098abe8205894e337
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Author: Julien Le Dem <julien@dremio.com> Closes apache#407 from julienledem/time_md and squashes the following commits: 3f721e2 [Julien Le Dem] ARROW-673: [Java] Support additional Time metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.