ARROW-637: [Format] Add timezone to Timestamp metadata, comments describing the semantics #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia25ca11dd7f64afc8ccedb98061a0e8e5f259423
Change-Id: I0ea0e5deef284c4c0643da1c0dd14f02b71ca068
BryanCutler
reviewed
Mar 17, 2017
| /// | ||
| /// * If the time zone is null or equal to an empty string, the data is "time | ||
| /// zone naive" and shall be displayed *as is* to the user, not localized | ||
| /// to the locale of the user. This data can be though of as UTC but |
Member
|
Sounds good! |
julienledem
reviewed
Mar 17, 2017
| /// | ||
| /// * As used in the Olson time zone database (the "tz database" or | ||
| /// "tzdata"), such as "America/New_York" | ||
| /// * An absolute time zone offset of the form +XX:XX or -XX:XX, such as +07:30 |
Member
There was a problem hiding this comment.
@julianhyde: any comment on the timezone format? Does it look good to you?
Member
Author
There was a problem hiding this comment.
I think this corresponds to our discussion on the JIRA, at least
Member
There was a problem hiding this comment.
Right: Julian clarified here:
https://issues.apache.org/jira/browse/ARROW-637?focusedCommentId=15928783&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15928783
Sorry for the duplicated question.
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…gets auto generated @wesm Thanks for the tip on fixing this. Author: Deepak Majeti <deepak.majeti@hpe.com> Closes apache#388 from majetideepak/PARQUET-1088 and squashes the following commits: 32915c6 [Deepak Majeti] add parquet_version.h to gitignore 48be6e2 [Deepak Majeti] Fix CMAKE arguments Change-Id: I98d8675ea57ad183e651399de208a3abf347905c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @julianhyde @julienledem for comment. This makes Arrow semantically equivalent to datetime objects in Python, and I believe the SQL standard