Skip to content

ARROW-637: [Format] Add timezone to Timestamp metadata, comments describing the semantics #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 3 commits into from
Closed

ARROW-637: [Format] Add timezone to Timestamp metadata, comments describing the semantics #388

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a25967a
Add timezone to Timestamp metadata, comments describing the semantics
wesm Mar 16, 2017
3fc10d6
typo
wesm Mar 16, 2017
e4661a4
Allow for absolute time zone offsets
wesm Mar 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions format/Message.fbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,28 @@ table Time {
/// time from the Unix epoch, 00:00:00.000 on 1 January 1970, UTC.
table Timestamp {
unit: TimeUnit;

/// The time zone is a string indicating the name of a time zone, one of:
///
/// * As used in the Olson time zone database (the "tz database" or
/// "tzdata"), such as "America/New_York"
/// * An absolute time zone offset of the form +XX:XX or -XX:XX, such as +07:30
Copy link
Member

@julienledem julienledem Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianhyde: any comment on the timezone format? Does it look good to you?

Copy link
Member Author

@wesm wesm Mar 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this corresponds to our discussion on the JIRA, at least

Copy link
Member

@julienledem julienledem Mar 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right: Julian clarified here:
https://issues.apache.org/jira/browse/ARROW-637?focusedCommentId=15928783&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15928783
Sorry for the duplicated question.

///
/// Whether a timezone string is present indicates different semantics about
/// the data:
///
/// * If the time zone is null or equal to an empty string, the data is "time
/// zone naive" and shall be displayed *as is* to the user, not localized
/// to the locale of the user. This data can be though of as UTC but
Copy link
Member

@BryanCutler BryanCutler Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: though -> thought

/// without having "UTC" as the time zone, it is not considered to be
/// localized to any time zone
///
/// * If the time zone is set to a valid value, values can be displayed as
/// "localized" to that time zone, even though the underlying 64-bit
/// integers are identical to the same data stored in UTC. Converting
/// between time zones is a metadata-only operation and does not change the
/// underlying values
timezone: string;
}

enum IntervalUnit: short { YEAR_MONTH, DAY_TIME}
Expand Down