GH-39549: [C++] Pass -jN to make in external projects #39550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@github-actions crossbow submit -g cpp r-binary-packages test-r-arrow-backwards-compatibility |
|
Revision: 581f538 Submitted crossbow builds: ursacomputing/crossbow @ actions-c14d91fbea
|
Member
Author
|
The fedora 38 and r-binary failures are unrelated |
kou
approved these changes
Jan 10, 2024
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
I'm not sure that this is safe for all cases but I'm OK if it works. :-)
kou
changed the title
github-actions
bot
added
awaiting merge
pitrou
approved these changes
Jan 11, 2024
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
No problem from me if CI passes :-)
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit adef537. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
assignUser
added a commit
that referenced
this pull request
Jan 17, 2024
### Rationale for this change Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16. ### What changes are included in this PR? Remove special casing from jemalloc, pass -jN to all make based eps. ### Are these changes tested? CI * Closes: #39549 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…9550) ### Rationale for this change Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16. ### What changes are included in this PR? Remove special casing from jemalloc, pass -jN to all make based eps. ### Are these changes tested? CI * Closes: apache#39549 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Previous issues with sub-make fragility are no longer an issue with our new minimum CMake version 3.16.
What changes are included in this PR?
Remove special casing from jemalloc, pass -jN to all make based eps.
Are these changes tested?
CI