GH-39734: [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 #39696

vibhatha · 2024-01-19T02:23:30Z

Rationale for this change

This PR was created to replace #39374 and do the necessary changes for org.codehaus.mojo upgrade to take place.

What changes are included in this PR?

The changes to the org.codehaus.mojo version and an upgrade on the maven version used in the .env.

Are these changes tested?

Tested locally, but this requires a CI verification on Java.

Are there any user-facing changes?

No

vibhatha · 2024-01-19T02:23:49Z

@github-actions crossbow submit java

github-actions · 2024-01-19T02:26:10Z

Revision: e1c246622418456d6582df60db993b4a67b0166c

Submitted crossbow builds: ursacomputing/crossbow @ actions-723588355a

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

raulcd

Thanks @vibhatha !
The integration failure seems related:

 Error:  Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.1:exec (run-java-benchmarks) on project arrow-performance: The plugin org.codehaus.mojo:exec-maven-plugin:3.1.1 requires Maven version 3.6.3 -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginIncompatibleException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <goals> -rf :arrow-performance

Also, this should not be MINOR and we should create an issue for it.

vibhatha · 2024-01-19T11:17:19Z

@raulcd let me check this. 👍

vibhatha · 2024-01-22T12:34:23Z

@raulcd is there a way to re-run the CIs.

I looked into the logs and noticed that the environment already has MAVEN 3.6.3

Error:  Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.1:exec (run-java-benchmarks) on project arrow-performance: The plugin org.codehaus.mojo:exec-maven-plugin:3.1.1 requires Maven version 3.6.3 -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginIncompatibleException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <goals> -rf :arrow-performance
1
Error: `docker-compose --file /home/runner/work/arrow/arrow/docker-compose.yml run --rm -e ARCHERY_DEFAULT_BRANCH=main -e ARCHERY_INTEGRATION_WITH_RUST=1 conda-integration` exited with a non-zero exit code 1, see the process log above.

The docker-compose command was invoked with the following parameters:

Defaults defined in .env:
  ALMALINUX: 8
  ALPINE_LINUX: 3.16
  ARCH: amd64
  ARCH_ALIAS: x86_64
  ARCH_SHORT: amd64
  ARROW_R_DEV: TRUE
  BUILDKIT_INLINE_CACHE: 1
  CLANG_TOOLS: 14
  COMPOSE_DOCKER_CLI_BUILD: 1
  CONAN: gcc10
  CUDA: 11.2.2
  DASK: latest
  DEBIAN: 11
  DEVTOOLSET_VERSION: 
  DOCKER_BUILDKIT: 1
  DOCKER_VOLUME_PREFIX: 
  DOTNET: 7.0
  FEDORA: 38
  GCC_VERSION: 
  GO: 1.19.13
  HDFS: 3.2.1
  JDK: 8
  KARTOTHEK: latest
  LLVM: 14
  MAVEN: 3.6.3
  NODE: 18
  NUMBA: latest
  NUMPY: latest
  PANDAS: latest
  PYTHON: 3.8
  PYTHON_WHEEL_WINDOWS_IMAGE_REVISION: 2023-08-02
  R: 4.2
  REPO: apache/arrow-dev
  R_CUSTOM_CCACHE: false
  R_IMAGE: ubuntu-gcc-release
  R_ORG: rhub
  R_PRUNE_DEPS: FALSE
  R_TAG: latest
  SPARK: master
  STATICCHECK: v0.4.5
  TURBODBC: latest
  TZ: UTC
  UBUNTU: 20.04
  ULIMIT_CORE: -1

vibhatha · 2024-01-22T12:43:54Z

@github-actions crossbow submit java

github-actions · 2024-01-22T12:46:12Z

Revision: e1c246622418456d6582df60db993b4a67b0166c

Submitted crossbow builds: ursacomputing/crossbow @ actions-ce9ed1dcce

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

lidavidm · 2024-01-22T14:42:48Z

I kicked the job.

vibhatha · 2024-01-22T14:48:11Z

Thanks @lidavidm

lidavidm · 2024-01-22T16:11:08Z

It appears it's still failing. You'll want to dig into the image, perhaps it's picking up the wrong Maven.

vibhatha · 2024-01-23T00:50:04Z

Yeah. Will analyze this. Thanks @lidavidm

vibhatha · 2024-01-23T03:49:07Z

@raulcd created a ticket: #39734

How can we link to this PR? 🙂

vibhatha · 2024-01-23T06:43:54Z

Thanks @assignUser

github-actions · 2024-01-24T01:40:45Z

Revision: 6ea7e1f

Submitted crossbow builds: ursacomputing/crossbow @ actions-554e5c5e99

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-01-24T03:39:41Z

@github-actions crossbow submit java

github-actions · 2024-01-24T03:42:10Z

Revision: 4b059ac

Submitted crossbow builds: ursacomputing/crossbow @ actions-77c87708fd

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-02-02T10:19:13Z

@github-actions crossbow submit java

github-actions · 2024-02-02T10:21:26Z

Revision: 4b059ac

Submitted crossbow builds: ursacomputing/crossbow @ actions-000ede4aab

Task	Status
java-jars
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

lidavidm · 2024-02-02T17:24:46Z

@raulcd any more comments here?

raulcd

Thanks!

conbench-apache-arrow · 2024-02-03T01:34:36Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 0fb00fd.

There was 1 benchmark result indicating a performance regression:

Commit Run on ec2-m5-4xlarge-us-east-2 at 2024-02-02 21:10:00Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-14, scale_factor=10

The full Conbench report has more details.

This is a follow-up of apacheGH-39696.

…9993) ### Rationale for this change GH-39696 updated Maven version but `ubuntu-docs` haven't used it yet. ### What changes are included in this PR? Use `MAVEN` in `.env` in `ubuntu-docs`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #39992 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

…1.6.0 to 3.1.1 (apache#39696) ### Rationale for this change This PR was created to replace apache#39374 and do the necessary changes for `org.codehaus.mojo` upgrade to take place. ### What changes are included in this PR? The changes to the `org.codehaus.mojo` version and an upgrade on the maven version used in the `.env`. ### Are these changes tested? Tested locally, but this requires a CI verification on Java. ### Are there any user-facing changes? No Authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

…nv (apache#39993) ### Rationale for this change apacheGH-39696 updated Maven version but `ubuntu-docs` haven't used it yet. ### What changes are included in this PR? Use `MAVEN` in `.env` in `ubuntu-docs`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39992 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

…1.6.0 to 3.1.1 (apache#39696) ### Rationale for this change This PR was created to replace apache#39374 and do the necessary changes for `org.codehaus.mojo` upgrade to take place. ### What changes are included in this PR? The changes to the `org.codehaus.mojo` version and an upgrade on the maven version used in the `.env`. ### Are these changes tested? Tested locally, but this requires a CI verification on Java. ### Are there any user-facing changes? No Authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actions bot added Component: Java awaiting review Awaiting review labels Jan 19, 2024

vibhatha marked this pull request as ready for review January 19, 2024 03:03

vibhatha requested review from assignUser, kou, lidavidm and raulcd as code owners January 19, 2024 03:03

vibhatha self-assigned this Jan 19, 2024

raulcd requested changes Jan 19, 2024

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 19, 2024

vibhatha changed the title ~~MINOR: [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 in /java V2~~ [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 Jan 22, 2024

feat: initial changes for upgrade

75448b1

assignUser changed the title ~~[Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1~~ GH-39734: [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 Jan 23, 2024

vibhatha force-pushed the feat-bump-org.codehaus.mojo-3.1.1 branch from e1c2466 to 75448b1 Compare January 23, 2024 04:35

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 23, 2024

test: maven version in ci

df95432

github-actions bot added the awaiting change review Awaiting change review label Jan 24, 2024

vibhatha requested a review from lidavidm January 24, 2024 03:34

vibhatha added 2 commits January 24, 2024 09:07

fix: cleanup

6ed73c8

fix: cleanup

4b059ac

lidavidm approved these changes Jan 24, 2024

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jan 24, 2024

raulcd approved these changes Feb 2, 2024

View reviewed changes

lidavidm merged commit 0fb00fd into apache:main Feb 2, 2024

lidavidm removed the awaiting merge Awaiting merge label Feb 2, 2024

lidavidm mentioned this pull request Feb 2, 2024

[Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 #39734

Closed

kou added a commit to kou/arrow that referenced this pull request Feb 8, 2024

apacheGH-39992: [CI][Docs][Java] ubuntu-docs uses Maven version in .env

f3d5bc9

This is a follow-up of apacheGH-39696.

kou mentioned this pull request Feb 8, 2024

GH-39992: [CI][Docs][Java] ubuntu-docs uses Maven version in .env #39993

Merged

This was referenced Mar 18, 2024

[CI][Release][Java] verify-rc-source-java-linux-almalinux-8-amd64 failed with old Maven #40649

Closed

GH-40649: [CI][Release][Java] Use Maven 3.8 for verify-rc-source-java-linux-almalinux-8-amd64 #40650

Closed

GH-39734: [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 #39696

GH-39734: [Java] Bump org.codehaus.mojo:exec-maven-plugin from 1.6.0 to 3.1.1 #39696

Uh oh!

Conversation

vibhatha commented Jan 19, 2024

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

vibhatha commented Jan 19, 2024

Uh oh!

github-actions bot commented Jan 19, 2024

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

vibhatha commented Jan 19, 2024

Uh oh!

vibhatha commented Jan 22, 2024

Uh oh!

vibhatha commented Jan 22, 2024

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

lidavidm commented Jan 22, 2024

Uh oh!

vibhatha commented Jan 22, 2024

Uh oh!

lidavidm commented Jan 22, 2024

Uh oh!

vibhatha commented Jan 23, 2024

Uh oh!

vibhatha commented Jan 23, 2024

Uh oh!

vibhatha commented Jan 23, 2024

Uh oh!

github-actions bot commented Jan 24, 2024

Uh oh!

vibhatha commented Jan 24, 2024

Uh oh!

github-actions bot commented Jan 24, 2024

Uh oh!

vibhatha commented Feb 2, 2024

Uh oh!

github-actions bot commented Feb 2, 2024

Uh oh!

lidavidm commented Feb 2, 2024

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

conbench-apache-arrow bot commented Feb 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants