Skip to content

Conversation

@felipecrv
Copy link
Contributor

What changes are included in this PR?

Bump arrow-testing to include the latest commit.

@felipecrv felipecrv requested a review from pitrou April 11, 2024 00:35
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 11, 2024
@kou kou changed the title [MINOR][C++] Bump arrow-testing to include repro file for #41044 MINOR: [C++] Bump arrow-testing to include repro file for #41044 Apr 11, 2024
@kou
Copy link
Member

kou commented Apr 11, 2024

Could you also add this to run CI for C++?

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 1d10be3b5b..f9de0c245b 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -21,6 +21,7 @@ on:
   push:
     paths:
       - '.github/workflows/cpp.yml'
+      - '.gitmodules'
       - 'ci/docker/**'
       - 'ci/scripts/cpp_*'
       - 'ci/scripts/install_azurite.sh'
@@ -34,6 +35,7 @@ on:
   pull_request:
     paths:
       - '.github/workflows/cpp.yml'
+      - '.gitmodules'
       - 'ci/docker/**'
       - 'ci/scripts/cpp_*'
       - 'ci/scripts/install_azurite.sh'

@kou
Copy link
Member

kou commented Apr 11, 2024

Ah, it will not detect testing change... This?

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 1d10be3b5b..dd5abbe1b4 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -31,6 +31,7 @@ on:
       - 'cpp/**'
       - 'docker-compose.yml'
       - 'format/Flight.proto'
+      - 'testing'
   pull_request:
     paths:
       - '.github/workflows/cpp.yml'
@@ -44,6 +45,7 @@ on:
       - 'cpp/**'
       - 'docker-compose.yml'
       - 'format/Flight.proto'
+      - 'testing'
 
 concurrency:
   group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}

@felipecrv
Copy link
Contributor Author

Done.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felipecrv !

@pitrou pitrou merged commit b3b4521 into apache:main Apr 11, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Apr 11, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b3b4521.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

@felipecrv felipecrv deleted the bump_testing_data branch April 11, 2024 14:28
@apache apache deleted a comment from github-actions bot Apr 11, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
apache#41139)

### What changes are included in this PR?

Bump `arrow-testing` to include the latest commit.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants