-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [C++] Bump arrow-testing to include repro file for #41044 #41139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you also add this to run CI for C++? diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 1d10be3b5b..f9de0c245b 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -21,6 +21,7 @@ on:
push:
paths:
- '.github/workflows/cpp.yml'
+ - '.gitmodules'
- 'ci/docker/**'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh'
@@ -34,6 +35,7 @@ on:
pull_request:
paths:
- '.github/workflows/cpp.yml'
+ - '.gitmodules'
- 'ci/docker/**'
- 'ci/scripts/cpp_*'
- 'ci/scripts/install_azurite.sh' |
|
Ah, it will not detect diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 1d10be3b5b..dd5abbe1b4 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -31,6 +31,7 @@ on:
- 'cpp/**'
- 'docker-compose.yml'
- 'format/Flight.proto'
+ - 'testing'
pull_request:
paths:
- '.github/workflows/cpp.yml'
@@ -44,6 +45,7 @@ on:
- 'cpp/**'
- 'docker-compose.yml'
- 'format/Flight.proto'
+ - 'testing'
concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} |
|
Done. |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felipecrv !
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b3b4521. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
apache#41139) ### What changes are included in this PR? Bump `arrow-testing` to include the latest commit. Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
What changes are included in this PR?
Bump
arrow-testingto include the latest commit.