Skip to content

GH-41427: [Go] Fix stateless prepared statements#41428

Merged
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-41427
Apr 29, 2024
Merged

GH-41427: [Go] Fix stateless prepared statements#41428
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-41427

Conversation

@lidavidm
Copy link
Copy Markdown
Member

@lidavidm lidavidm commented Apr 29, 2024

Rationale for this change

Stateless prepared statements didn't actually work

What changes are included in this PR?

Update the handle after binding parameters

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread go/arrow/flight/flightsql/client_test.go
@github-actions github-actions Bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting merge Awaiting merge labels Apr 29, 2024
@lidavidm lidavidm merged commit d60ff53 into apache:main Apr 29, 2024
@lidavidm lidavidm removed the awaiting changes Awaiting changes label Apr 29, 2024
@lidavidm lidavidm deleted the gh-41427 branch April 29, 2024 23:46
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d60ff53.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

@matthewmturner
Copy link
Copy Markdown

@lidavidm FYI we are still seeing having issues with stateless prepared statements from go. It seems to be working from a rust client but something going on with the deserialization of the handle where the data in handle is ending up unknown fields of DoPutPreparedStatementResult instead of prepared_statement_handle.

It's possible that the issue is actually on our side but given that the rust client worked without issue I'm inclined to think its on the go client side. I am looking into it, but wanted to raise it here as well.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants