-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-5174: [Go] implement Stringer for DataTypes #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
needs #4160 |
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
===========================================
- Coverage 87.89% 60.53% -27.36%
===========================================
Files 758 67 -691
Lines 92163 4974 -87189
Branches 1251 0 -1251
===========================================
- Hits 81006 3011 -77995
+ Misses 11040 1847 -9193
+ Partials 117 116 -1
Continue to review full report at Codecov.
|
b7a0359 to
65173bd
Compare
|
(the Travis-CI error is unrelated (JDK-9 is acting up?)) |
|
LGTM (except for arrow-cat and arrow-main that I did not fully review since I need read the whole thing first :)) |
|
thanks. feel free to comment on the PR(s) that I might have already collected and I'll retrofit those comments. |
stuartcarnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Needs #4161. Author: Sebastien Binet <binet@cern.ch> Closes #4228 from sbinet/issue-5233 and squashes the following commits: 323540c <Sebastien Binet> go/arrow/ipc: adapt to new flabuffers-v1.11 e82c908 <Sebastien Binet> go/arrow/ipc/feather: update format bca7dda <Sebastien Binet> go/arrow/internal/flatbuf: update format 93c7c5e <Sebastien Binet> ARROW-5233: Migrate to flatbuffers-v1.11.0
No description provided.