Skip to content

Conversation

@sbinet
Copy link
Contributor

@sbinet sbinet commented Apr 16, 2019

No description provided.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 16, 2019

needs #4160

@codecov-io
Copy link

Codecov Report

Merging #4161 into master will decrease coverage by 27.35%.
The diff coverage is 26.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4161       +/-   ##
===========================================
- Coverage   87.89%   60.53%   -27.36%     
===========================================
  Files         758       67      -691     
  Lines       92163     4974    -87189     
  Branches     1251        0     -1251     
===========================================
- Hits        81006     3011    -77995     
+ Misses      11040     1847     -9193     
+ Partials      117      116        -1
Impacted Files Coverage Δ
go/arrow/ipc/file_reader.go 0% <0%> (ø) ⬆️
go/arrow/array/list.go 74.56% <0%> (-12.18%) ⬇️
go/arrow/ipc/metadata.go 0% <0%> (ø) ⬆️
go/arrow/datatype_binary.go 0% <0%> (ø) ⬆️
go/arrow/array/struct.go 84.31% <100%> (+11.67%) ⬆️
go/arrow/datatype_nested.go 75% <16.66%> (-19.74%) ⬇️
go/arrow/datatype_fixedwidth.go 22.72% <25%> (-8.53%) ⬇️
go/arrow/datatype_numeric.gen.go 37.5% <37.5%> (-12.5%) ⬇️
go/arrow/datatype_null.go 66.66% <66.66%> (-33.34%) ⬇️
go/arrow/array/fixedsize_binary.go 73.8% <79.16%> (+5.38%) ⬆️
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0930d...e6ec020. Read the comment docs.

@sbinet sbinet force-pushed the issue-5174 branch 2 times, most recently from b7a0359 to 65173bd Compare April 29, 2019 08:30
@sbinet
Copy link
Contributor Author

sbinet commented Apr 29, 2019

@sbinet
Copy link
Contributor Author

sbinet commented Apr 29, 2019

(the Travis-CI error is unrelated (JDK-9 is acting up?))

@alexandreyc
Copy link
Contributor

LGTM

(except for arrow-cat and arrow-main that I did not fully review since I need read the whole thing first :))

@sbinet
Copy link
Contributor Author

sbinet commented Apr 30, 2019

thanks.

feel free to comment on the PR(s) that I might have already collected and I'll retrofit those comments.

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sbinet sbinet closed this in 8a41288 Apr 30, 2019
@sbinet sbinet deleted the issue-5174 branch April 30, 2019 20:21
wesm pushed a commit that referenced this pull request May 3, 2019
Needs #4161.

Author: Sebastien Binet <binet@cern.ch>

Closes #4228 from sbinet/issue-5233 and squashes the following commits:

323540c <Sebastien Binet> go/arrow/ipc: adapt to new flabuffers-v1.11
e82c908 <Sebastien Binet> go/arrow/ipc/feather: update format
bca7dda <Sebastien Binet> go/arrow/internal/flatbuf: update format
93c7c5e <Sebastien Binet> ARROW-5233:  Migrate to flatbuffers-v1.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants