Skip to content

ARROW-5233: [Go] Migrate to flatbuffers-v1.11.0 #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbinet wants to merge 4 commits into from
Closed

ARROW-5233: [Go] Migrate to flatbuffers-v1.11.0 #4228

sbinet wants to merge 4 commits into from

Conversation

@sbinet
Copy link
Contributor

@sbinet sbinet commented Apr 30, 2019

Needs #4161.

@sbinet sbinet mentioned this pull request Apr 30, 2019
Closed
@sbinet
Copy link
Contributor Author

sbinet commented Apr 30, 2019

PTAL @stuartcarnie @alexandreyc @nickpoorman

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #4228 into master will decrease coverage by 21.63%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #4228       +/-   ##
==========================================
- Coverage   88.04%   66.4%   -21.64%     
==========================================
  Files         758      67      -691     
  Lines       92803    4992    -87811     
  Branches     1251       0     -1251     
==========================================
- Hits        81708    3315    -78393     
+ Misses      10982    1572     -9410     
+ Partials      113     105        -8
Impacted Files Coverage Δ
go/arrow/ipc/metadata.go 0% <0%> (ø) ⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
... and 682 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a41288...323540c. Read the comment docs.

@wesm
Copy link
Member

wesm commented May 3, 2019

merging shortly

@wesm wesm closed this in 7f722b2 May 3, 2019
@sbinet sbinet deleted the issue-5233 branch May 6, 2019 10:24
sbinet added a commit that referenced this pull request May 6, 2019
@sbinet
ARROW-5112: [Go] implement writing IPC Arrow stream/file
4f6fb56 
Needs #4228.

Author: Sebastien Binet <binet@cern.ch>

Closes #4229 from sbinet/issue-5112 and squashes the following commits:

d264ebb <Sebastien Binet> go/arrow/{ipc,internal/arrdata}: implement List/Struct writing, add tests
53ab9ce <Sebastien Binet> go/arrow/array: add ValueOffset to String array
c2484d3 <Sebastien Binet> go/arrow/array: fix ref-count for Struct array
11bd334 <Sebastien Binet> go/arrow/array: fix ref-count for List array
aba5551 <Sebastien Binet> go/arrow/array: implement Stringer for Binary array
7cdc3c0 <Sebastien Binet> go/arrow/ipc: test r/w with mask
d7a5a89 <Sebastien Binet> go/arrow/internal/bitutil: add CeilByte64 and BytesForBits
5f37572 <Sebastien Binet> ARROW-5112:  implement writing IPC Arrow stream/file
@asfimport asfimport mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@nickpoorman nickpoorman nickpoorman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbinet @codecov-io @wesm @stuartcarnie @nickpoorman