-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-5112: [Go] implement writing IPC Arrow stream/file #4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nickpoorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stuartcarnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a large PR, so I was looking though the commits for tests. I don't have a sense of the amount of coverage but I do see lots of tests.
LGTM 🎉
|
yeah... I don't know why the code coverage app didn't post its report... |
Codecov Report
@@ Coverage Diff @@
## master #4229 +/- ##
===========================================
- Coverage 88.27% 71.83% -16.45%
===========================================
Files 763 71 -692
Lines 93723 5943 -87780
Branches 1251 0 -1251
===========================================
- Hits 82735 4269 -78466
+ Misses 10875 1446 -9429
- Partials 113 228 +115
Continue to review full report at Codecov.
|
7d58806 to
5b59ae6
Compare
Needs #4228.