Skip to content

Conversation

@sbinet
Copy link
Contributor

@sbinet sbinet commented Apr 30, 2019

Needs #4228.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 30, 2019

Copy link
Contributor

@nickpoorman nickpoorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a large PR, so I was looking though the commits for tests. I don't have a sense of the amount of coverage but I do see lots of tests.

LGTM 🎉

@sbinet
Copy link
Contributor Author

sbinet commented May 1, 2019

yeah... I don't know why the code coverage app didn't post its report...
I'll try to post mine in the coming days.

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #4229 into master will decrease coverage by 16.44%.
The diff coverage is 68.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4229       +/-   ##
===========================================
- Coverage   88.27%   71.83%   -16.45%     
===========================================
  Files         763       71      -692     
  Lines       93723     5943    -87780     
  Branches     1251        0     -1251     
===========================================
- Hits        82735     4269    -78466     
+ Misses      10875     1446     -9429     
- Partials      113      228      +115
Impacted Files Coverage Δ
go/arrow/internal/bitutil/bitutil.go 90.32% <0%> (-3.02%) ⬇️
go/arrow/array/struct.go 81.13% <0%> (-3.19%) ⬇️
go/arrow/array/binary.go 62.74% <0%> (-21.47%) ⬇️
go/arrow/array/list.go 72.64% <0%> (-1.92%) ⬇️
go/arrow/ipc/ipc.go 75% <100%> (+75%) ⬆️
go/arrow/ipc/file_reader.go 58.14% <40%> (+58.14%) ⬆️
go/arrow/array/string.go 74.6% <50%> (-1.21%) ⬇️
go/arrow/ipc/reader.go 55.22% <50%> (+55.22%) ⬆️
go/arrow/ipc/metadata.go 63.58% <67.91%> (+63.58%) ⬆️
go/arrow/ipc/file_writer.go 69.03% <69.03%> (ø)
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982f341...d264ebb. Read the comment docs.

@sbinet sbinet force-pushed the issue-5112 branch 2 times, most recently from 7d58806 to 5b59ae6 Compare May 6, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants