Skip to content

MINOR: [Java] Update issue management config in pom.xml #43191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jul 9, 2024
Merged

MINOR: [Java] Update issue management config in pom.xml #43191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bc01ea
MINOR: [Java] Update issue management config in pom.xml
danepitkin Jul 8, 2024
7020910
Update CONTRIBUTING.md
danepitkin Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ We prefer to receive contributions in the form of GitHub pull requests. Please
send pull requests against the [github.com/apache/arrow][4] repository following
the procedure below.

If you are looking for some ideas on what to contribute, check out the [JIRA
If you are looking for some ideas on what to contribute, check out the [GitHub
issues][3] for the Apache Arrow project. Comment on the issue and/or contact
[dev@arrow.apache.org](https://lists.apache.org/list.html?dev@arrow.apache.org)
with your questions and ideas.
Expand All @@ -53,8 +53,8 @@ To contribute a patch:

1. Break your work into small, single-purpose patches if possible. It’s much
harder to merge in a large change with a lot of disjoint features.
2. If one doesn't already exist, create a JIRA for your patch on the [Arrow Project
JIRA](https://issues.apache.org/jira/browse/ARROW).
2. If one doesn't already exist, create a GitHub issue for your patch on the [Arrow Project
GitHub](https://github.com/apache/arrow/issues).
3. Submit the patch as a GitHub pull request against the main branch. For a
tutorial, see the GitHub guides on [forking a repo](https://help.github.com/en/articles/fork-a-repo)
and [sending a pull request](https://help.github.com/en/articles/creating-a-pull-request-from-a-fork). So that your pull request syncs with the JIRA issue, prefix your pull request
Expand All @@ -68,5 +68,5 @@ Thank you in advance for your contributions!

[1]: mailto:dev-subscribe@arrow.apache.org
[2]: https://github.com/apache/arrow/tree/main/format
[3]: https://issues.apache.org/jira/browse/ARROW
[3]: https://github.com/apache/arrow/issues
[4]: https://github.com/apache/arrow
4 changes: 2 additions & 2 deletions java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ under the License.
</scm>

<issueManagement>
<system>Jira</system>
<url>https://issues.apache.org/jira/browse/arrow</url>
<system>GitHub</system>
Copy link
Contributor

@laurentgo laurentgo Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because maven/pom.xml and bom/pom.xml do not inherit from the top-level pom.xml. you may want to change those as well (note that maven/pom.xml is being removed as part of #43139)

Copy link
Member Author

@danepitkin danepitkin Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I didn't think to look for other uses.

Copy link
Member Author

@danepitkin danepitkin Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we don't populate <issueManagement> in the other poms. Is it typical to add it?

Copy link
Contributor

@vibhatha vibhatha Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure whether we need this?
cc @lidavidm

Copy link
Member

@lidavidm lidavidm Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearly not strictly necessary, so I'd rather we just take the update here?

Copy link
Contributor

@laurentgo laurentgo Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but nice to have. It may be used by tools and shows up in the site generated by Maven or also accessible from websites like Maven Central.

You can check and compare the pages for arrow-memory-core and arrow-bom

Copy link
Member Author

@danepitkin danepitkin Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Project URL and Source Control are also not configured correctly for maven central. Thanks for sharing.

<url>https://github.com/apache/arrow/issues</url>
</issueManagement>

<properties>
Expand Down