-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [Java] Update issue management config in pom.xml #43191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <issueManagement> | ||
| <system>Jira</system> | ||
| <url>https://issues.apache.org/jira/browse/arrow</url> | ||
| <system>GitHub</system> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because maven/pom.xml and bom/pom.xml do not inherit from the top-level pom.xml. you may want to change those as well (note that maven/pom.xml is being removed as part of #43139)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, I didn't think to look for other uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out we don't populate <issueManagement> in the other poms. Is it typical to add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not sure whether we need this?
cc @lidavidm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clearly not strictly necessary, so I'd rather we just take the update here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary but nice to have. It may be used by tools and shows up in the site generated by Maven or also accessible from websites like Maven Central.
You can check and compare the pages for arrow-memory-core and arrow-bom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Project URL and Source Control are also not configured correctly for maven central. Thanks for sharing.
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8fc40fc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Update the issue management config in Java's parent pom. ### What changes are included in this PR? * Change issue management config from Jira to GitHub ### Are these changes tested? n/a Authored-by: Dane Pitkin <dpitkin@apache.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Update the issue management config in Java's parent pom.
What changes are included in this PR?
Are these changes tested?
n/a