Skip to content

Conversation

@danepitkin
Copy link
Member

Rationale for this change

Update the issue management config in Java's parent pom.

What changes are included in this PR?

  • Change issue management config from Jira to GitHub

Are these changes tested?

n/a

@danepitkin danepitkin requested a review from vibhatha July 8, 2024 20:01
@danepitkin danepitkin requested a review from lidavidm as a code owner July 8, 2024 20:01
<issueManagement>
<system>Jira</system>
<url>https://issues.apache.org/jira/browse/arrow</url>
<system>GitHub</system>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because maven/pom.xml and bom/pom.xml do not inherit from the top-level pom.xml. you may want to change those as well (note that maven/pom.xml is being removed as part of #43139)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I didn't think to look for other uses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we don't populate <issueManagement> in the other poms. Is it typical to add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure whether we need this?
cc @lidavidm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearly not strictly necessary, so I'd rather we just take the update here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but nice to have. It may be used by tools and shows up in the site generated by Maven or also accessible from websites like Maven Central.

You can check and compare the pages for arrow-memory-core and arrow-bom

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Project URL and Source Control are also not configured correctly for maven central. Thanks for sharing.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jul 8, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Jul 8, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 8fc40fc into apache:main Jul 9, 2024
@kou kou removed the awaiting merge Awaiting merge label Jul 9, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 9, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8fc40fc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
### Rationale for this change

Update the issue management config in Java's parent pom.

### What changes are included in this PR?

* Change issue management config from Jira to GitHub

### Are these changes tested?

n/a

Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants