Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 1, 2024

Rationale for this change

When ensuring the data we are pretty-printing is on the CPU, we can use ViewOrCopyTo instead of CopyTo, in case the data can be viewed as CPU data without a copy.

Are these changes tested?

Yes (I added a test that uses CUDA host memory, which should be a case where it can be viewed and doesn't need to be copied, but of course the test it not actually ensuring we avoid the copy, just that the printing works)

Are there any user-facing changes?

No

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-cuda-cpp test-cuda-python

@github-actions
Copy link

github-actions bot commented Aug 1, 2024

Revision: 1760a86

Submitted crossbow builds: ursacomputing/crossbow @ actions-ac5d396a7c

Task Status
test-cuda-cpp GitHub Actions
test-cuda-python GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b35e7dd into apache:main Aug 2, 2024
@kou kou removed the awaiting committer review Awaiting committer review label Aug 2, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 2, 2024
@jorisvandenbossche jorisvandenbossche deleted the gh-43507-pretty-print-vieworcopy branch August 2, 2024 06:37
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b35e7dd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants