Skip to content

GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data #43508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Aug 2, 2024
Merged

GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data #43508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/arrow/pretty_print.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@ class ArrayPrinter : public PrettyPrinter {
if (array.device_type() != DeviceAllocationType::kCPU) {
// GH-43055: ideally we only copy start/end slices from non-CPU memory
// based on the window size that is being printed
ARROW_ASSIGN_OR_RAISE(auto array_cpu, array.CopyTo(default_cpu_memory_manager()));
ARROW_ASSIGN_OR_RAISE(auto array_cpu,
array.ViewOrCopyTo(default_cpu_memory_manager()));
RETURN_NOT_OK(VisitArrayInline(*array_cpu, this));
} else {
RETURN_NOT_OK(VisitArrayInline(array, this));
Expand Down
11 changes: 11 additions & 0 deletions python/pyarrow/tests/test_cuda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,17 @@ def test_print_array():
assert str(carr) == str(arr)


@pytest.mark.parametrize("size", [10, 100])
def test_print_array_host(size):
buf = cuda.new_host_buffer(size*8)
np_arr = np.frombuffer(buf, dtype=np.int64)
np_arr[:] = range(size)

arr = pa.array(range(size), pa.int64())
carr = pa.Array.from_buffers(pa.int64(), size, [None, buf])
assert str(carr) == str(arr)


def make_chunked_array(n_elements_per_chunk, n_chunks):
arrs = []
carrs = []
Expand Down