Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Sep 12, 2024

Rationale for this change

We currently build Windows wheels with S3 enabled, but we disable it for testing.

What changes are included in this PR?

Ensure Minio is installed and re-enable S3 for testing.

Are these changes tested?

Yes, by construction (on CI).

Are there any user-facing changes?

No.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou
Copy link
Member Author

pitrou commented Sep 12, 2024

@github-actions crossbow submit wheelwin*

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 12, 2024
@github-actions

This comment was marked as outdated.

@pitrou pitrou changed the title DRAFT: [CI][Python] Enable S3 testing for Windows wheels GH-44095: [CI][Python] Enable S3 testing on Windows wheel builds Sep 12, 2024
@github-actions
Copy link

⚠️ GitHub issue #44095 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Sep 12, 2024

@github-actions crossbow submit wheel-windows-*

@github-actions
Copy link

Revision: 7ee9186

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c69e5dac0

Task Status
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp313-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@pitrou pitrou marked this pull request as ready for review September 12, 2024 19:53
@kou
Copy link
Member

kou commented Sep 13, 2024

Hmm. It seems that s3fs isn't built...

https://github.com/ursacomputing/crossbow/actions/runs/10836975764/job/30071907274#step:9:951

SKIPPED [1] Python312\Lib\site-packages\pyarrow\tests\test_fs.py:607: could not import 's3fs': No module named 's3fs'

@kou
Copy link
Member

kou commented Sep 13, 2024

Ah, it's not pyarrow._s3fs.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 13, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 13, 2024

Ah, it's not pyarrow._s3fs.

Yes, it's always confusing :) The error message is talking about https://pypi.org/project/s3fs/.

@pitrou pitrou merged commit a828bd2 into apache:main Sep 13, 2024
@pitrou pitrou removed the awaiting merge Awaiting merge label Sep 13, 2024
@pitrou pitrou deleted the exp-win-wheel-s3-testing branch September 13, 2024 14:13
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit a828bd2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a828bd2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 35 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants