Skip to content

Conversation

@andishgar
Copy link
Contributor

@andishgar andishgar commented Feb 20, 2025

Rationale for this change

arrow::RecordBatch::MakeStatisticsArray()'s docstring uses https://arrow.apache.org/docs/format/CDataInterfaceStatistics.html not https://arrow.apache.org/docs/format/StatisticsSchema.html for statistics schema URL.

Because #44252 assumed that we use #43553 but we use #45058 finally.

What changes are included in this PR?

Fix URL.

Are these changes tested?

It does not need since just a correction in document

Are there any user-facing changes?

No, Just a correction in document

@github-actions
Copy link

⚠️ GitHub issue #45587 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Feb 20, 2025

@github-actions crossbow submit preview-docs

@kou kou changed the title GH-45587:[C++][Docs]fix the document incorrectness in MakeStatisticsArray method in RecordBatch class GH-45587: [C++][Docs] Fix the statistics schema link in arrow::RecordBatch::MakeStatisticsArray()'s docstring Feb 20, 2025
@github-actions
Copy link

Revision: 5eb7463

Submitted crossbow builds: ursacomputing/crossbow @ actions-30105cacf2

Task Status
preview-docs GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou kou merged commit 5e5fb07 into apache:main Feb 21, 2025
39 checks passed
@kou kou removed the awaiting review Awaiting review label Feb 21, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Feb 21, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5e5fb07.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

@andishgar andishgar deleted the fix_MakeStatisticsArray_doc_for_record_batch branch February 22, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants