GH-45930: [C++] Don't use ICU C++ API in Azure SDK C++ #45952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@github-actions crossbow submit debian-* |
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
Revision: 14d7c88 Submitted crossbow builds: ursacomputing/crossbow @ actions-52007f21f5
|
kou
commented
Mar 27, 2025
github-actions
bot
added
awaiting changes
pitrou
approved these changes
Mar 27, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f4b7a4e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
…45952) ### Rationale for this change ICU 75.1 or later requires C++17 but Azure SDK for C++ still uses C++14. Azure SDK for C++ includes ICU headers via libxml2. ### What changes are included in this PR? We don't need to use ICU C++ API. So we can disable ICU C++ API. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45930 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ICU 75.1 or later requires C++17 but Azure SDK for C++ still uses C++14. Azure SDK for C++ includes ICU headers via libxml2.
What changes are included in this PR?
We don't need to use ICU C++ API. So we can disable ICU C++ API.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.