Skip to content

GH-45930: [C++] Don't use ICU C++ API in Azure SDK C++ #45952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Mar 27, 2025
Merged

GH-45930: [C++] Don't use ICU C++ API in Azure SDK C++ #45952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14d7c88
GH-45930: [C++] Don't use ICU C++ API in Azure SDK C++
kou Mar 27, 2025
1a2b1a3
Add more note
kou Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5510,6 +5510,12 @@ function(build_azure_sdk)
set(BUILD_SAMPLES FALSE)
set(BUILD_TESTING FALSE)
set(BUILD_WINDOWS_UWP TRUE)
# ICU 75.1 or later requires C++17 but Azure SDK for C++ still uses
# C++14. So we disable C++ API in ICU.
#
# We can remove this after
# https://github.com/Azure/azure-sdk-for-cpp/pull/6486 is merged.
string(APPEND CMAKE_CXX_FLAGS " -DU_SHOW_CPLUSPLUS_API=0")
set(CMAKE_UNITY_BUILD FALSE)
set(DISABLE_AZURE_CORE_OPENTELEMETRY TRUE)
set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
Expand Down
Loading