GH-45978: [C++] Bump bundled mimalloc version #45979

pitrou · 2025-03-31T14:03:44Z

What changes are included in this PR?

Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.

Are these changes tested?

Yes, by CI builds.

Are there any user-facing changes?

No.

GitHub Issue: [C++] Bump bundled mimalloc version #45978

github-actions · 2025-03-31T14:04:16Z

⚠️ GitHub issue #45978 has been automatically assigned in GitHub to PR creator.

pitrou · 2025-03-31T14:04:25Z

@github-actions crossbow submit -g cpp -g python

pitrou · 2025-03-31T14:12:39Z

@github-actions crossbow submit -g cpp -g python

pitrou · 2025-03-31T14:40:43Z

I've opened microsoft/mimalloc#1056 for the Alpine Linux failure but I don't think it should be holding this.

assignUser

It looks like we also need to forward snappy
Edit: #45980

assignUser · 2025-03-31T15:24:41Z

.github/workflows/cpp.yml

      ARROW_SUBSTRAIT: ON
      ARROW_USE_GLOG: OFF
-      ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
+      ARROW_VERBOSE_THIRDPARTY_BUILD: ON


I assume you'll revert these before merge?

Yes, this was to debug the build/link errors on Windows which are now fixed.

pitrou · 2025-06-11T19:15:12Z

@github-actions crossbow submit -g cpp -g python

github-actions · 2025-06-11T19:18:14Z

Revision: 97490ec58b0ed1c9993b607aa0046bc7fbfde66a

Submitted crossbow builds: ursacomputing/crossbow @ actions-21dfeaf22e

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest-numpy-latest
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-1.26
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-pandas-nightly-numpy-nightly
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.13
test-conda-python-3.9
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5
test-conda-python-emscripten
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-39-cpp
test-fedora-39-python-3
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer
test-ubuntu-24.04-python-3

pitrou · 2025-06-11T20:02:37Z

@github-actions crossbow submit wheelcp313*

Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.

github-actions · 2025-06-11T20:05:15Z

Revision: 1fe3480

Submitted crossbow builds: ursacomputing/crossbow @ actions-dc8e7b294f

Task	Status
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-macos-monterey-cp313-cp313t-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313t-arm64
wheel-manylinux-2014-cp313-cp313-amd64
wheel-manylinux-2014-cp313-cp313-arm64
wheel-manylinux-2014-cp313-cp313t-amd64
wheel-manylinux-2014-cp313-cp313t-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-musllinux-1-2-cp313-cp313t-amd64
wheel-musllinux-1-2-cp313-cp313t-arm64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64

pitrou · 2025-06-11T20:45:53Z

This is ready for review @kou . CI looks good except for a probably unrelated failure in the Python emscripten build.

kou

+1

cpp/cmake_modules/ThirdpartyToolchain.cmake

conbench-apache-arrow · 2025-06-12T17:26:49Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0826be5.

There were 76 benchmark results with an error:

Commit Run on amd64-m5-4xlarge-linux at 2025-06-12 10:33:35Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-04, scale_factor=10
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-12, scale_factor=1
and 74 more (see the report linked below)

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 32 possible false positives for unstable benchmarks that are known to sometimes produce them.

### What changes are included in this PR? Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues. ### Are these changes tested? Yes, by CI builds. ### Are there any user-facing changes? No. * GitHub Issue: apache#45978 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

kou · 2025-07-04T21:34:37Z

@github-actions crossbow submit test-r-linux-sanitizers

github-actions · 2025-07-04T21:36:46Z

Revision: cc5d86e

Submitted crossbow builds: ursacomputing/crossbow @ actions-d6f9a3a132

Task	Status
test-r-linux-sanitizers

Tom-Newton · 2025-08-06T22:35:44Z

I think this change has caused a memory leak when reading parquet #47266

pitrou mentioned this pull request Mar 31, 2025

MINOR: [C++] Bump bundled mimalloc version #44941

Closed

github-actions bot added the Component: C++ label Mar 31, 2025

github-actions bot added the awaiting review Awaiting review label Mar 31, 2025

pitrou mentioned this pull request Mar 31, 2025

GH-45614: [C++] Use Boost's CMake packages instead of FindBoost.cmake in CMake #45623

Merged

This comment was marked as outdated.

Sign in to view

pitrou force-pushed the gh45978-bump-mimalloc branch from c9a3cbe to 161d91b Compare March 31, 2025 14:12

This comment was marked as outdated.

Sign in to view

pitrou requested review from assignUser, jonkeane, kou and raulcd as code owners March 31, 2025 14:34

pitrou mentioned this pull request Mar 31, 2025

Compilation failure on Alpine Linux microsoft/mimalloc#1056

Closed

pitrou force-pushed the gh45978-bump-mimalloc branch 2 times, most recently from 2185744 to 222ec0b Compare March 31, 2025 15:05

assignUser reviewed Mar 31, 2025

View reviewed changes

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 31, 2025

pitrou force-pushed the gh45978-bump-mimalloc branch from 8241964 to 97490ec Compare June 11, 2025 19:14

pitrou added the CI: Extra Run extra CI label Jun 11, 2025

apacheGH-45978: [C++] Bump bundled mimalloc version

1fe3480

Update bundled mimalloc version from 2.0.6 to 2.2.4. This will also help fix the CMake 4.0 compatibility issues.

pitrou force-pushed the gh45978-bump-mimalloc branch from 97490ec to 1fe3480 Compare June 11, 2025 20:03

kou approved these changes Jun 11, 2025

View reviewed changes

cpp/cmake_modules/ThirdpartyToolchain.cmake Outdated Show resolved Hide resolved

cpp/cmake_modules/ThirdpartyToolchain.cmake Show resolved Hide resolved

cpp/cmake_modules/ThirdpartyToolchain.cmake Outdated Show resolved Hide resolved

github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 11, 2025

Apply suggestions

cc5d86e

pitrou force-pushed the gh45978-bump-mimalloc branch from 5af7504 to cc5d86e Compare June 12, 2025 05:29

github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jun 12, 2025

pitrou merged commit 0826be5 into apache:main Jun 12, 2025
34 of 35 checks passed

pitrou removed the awaiting changes Awaiting changes label Jun 12, 2025

pitrou mentioned this pull request Jun 12, 2025

[C++] Bump bundled mimalloc version #45978

Closed

pitrou deleted the gh45978-bump-mimalloc branch June 12, 2025 08:00

pitrou mentioned this pull request Jun 12, 2025

Excessive memory retention using either mimalloc v2 or v3 on macOS microsoft/mimalloc#1025

Open

kou mentioned this pull request Jul 4, 2025

[CI][C++] test-r-linux-sanitizers is failing #46995

Closed

Tom-Newton mentioned this pull request Aug 6, 2025

[Python][Parquet] 21.0.0 release introduced memory leak when reading parquet #47266

Open

GH-45978: [C++] Bump bundled mimalloc version #45979

GH-45978: [C++] Bump bundled mimalloc version #45979

Uh oh!

Conversation

pitrou commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

pitrou commented Mar 31, 2025

Uh oh!

This comment was marked as outdated.

pitrou commented Mar 31, 2025

Uh oh!

This comment was marked as outdated.

pitrou commented Mar 31, 2025

Uh oh!

assignUser left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

assignUser Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

pitrou Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

pitrou commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

pitrou commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

pitrou commented Jun 11, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Jun 12, 2025

Uh oh!

kou commented Jul 4, 2025

Uh oh!

github-actions bot commented Jul 4, 2025

Uh oh!

Tom-Newton commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pitrou commented Mar 31, 2025 •

edited

Loading

assignUser left a comment •

edited

Loading