GH-45987: [C++] Set CMAKE_POLICY_VERSION_MINIMUM=3.5 for bundled dependencies #45997
Conversation
|
@github-actions crossbow submit -g cpp r-binary-packages |
|
|
Revision: f60ef50 Submitted crossbow builds: ursacomputing/crossbow @ actions-aaffa77392
|
| -DCMAKE_OSX_SYSROOT=${CMAKE_OSX_SYSROOT} | ||
| -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}) | ||
| -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE} | ||
| -DCMAKE_POLICY_VERSION_MINIMUM=3.5) |
There was a problem hiding this comment.
My only concern of adding this globally instead of adding this specifically as CMake args for the individual dependencies that have issues is that we might forget this flag (which should be temporary).
Should we add at least a note saying: # Remove once all dependencies for https://github.com/apache/arrow/issues/45985 have been updated ?
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit -g verify-rc-source |
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit f60ef50. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
it should also fix the benchmark builds |
|
Revision: f60ef50 Submitted crossbow builds: ursacomputing/crossbow @ actions-78a44adc1b
|
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
The remaining failures don't look related, can we merge this quickly? @assignUser
|
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit f60ef50. There were 27 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 48c0bbb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ndencies (#45997) ### Rationale for this change Enable building with CMake 4.0 and bundled dependencies that still set `cmake_minimum_required(VERSION 3.5)` or less. ### What changes are included in this PR? Set https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html ### Are these changes tested? CI ### Are there any user-facing changes? No * GitHub Issue: #45987 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
…d dependencies (apache#45997) ### Rationale for this change Enable building with CMake 4.0 and bundled dependencies that still set `cmake_minimum_required(VERSION 3.5)` or less. ### What changes are included in this PR? Set https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html ### Are these changes tested? CI ### Are there any user-facing changes? No * GitHub Issue: apache#45987 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
…d dependencies (apache#45997) ### Rationale for this change Enable building with CMake 4.0 and bundled dependencies that still set `cmake_minimum_required(VERSION 3.5)` or less. ### What changes are included in this PR? Set https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html ### Are these changes tested? CI ### Are there any user-facing changes? No * GitHub Issue: apache#45987 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
4 participants
Rationale for this change
Enable building with CMake 4.0 and bundled dependencies that still set
cmake_minimum_required(VERSION 3.5)or less.What changes are included in this PR?
Set https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html
Are these changes tested?
CI
Are there any user-facing changes?
No