GH-47836: [C++] Fix Meson configuration after bpacking changes #47837
Conversation
|
|
WillAyd
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
| if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then | ||
| ARROW_BUILD_EXAMPLES=OFF # TODO: Remove this | ||
| meson test \ | ||
| --max-lines=0 \ |
There was a problem hiding this comment.
I'm not familiar with this option but does this disable log output on failure?
There was a problem hiding this comment.
By default the test log only shows 100 lines of output. When there are many tests, the error sometimes isn't shown in the logs because it gets buffered out by other content. This makes it so the entire test log is shown on error
We made this same change in #47282, so I figured I'd just pull forwards here to reduce the diff on the other PR. Happy to drop this particular line for now
There was a problem hiding this comment.
Thanks. I'm not have a strong opinion for it. Let's keep this in this PR.
github-actions
bot
added
awaiting changes
| if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then | ||
| ARROW_BUILD_EXAMPLES=OFF # TODO: Remove this | ||
| meson test \ | ||
| --max-lines=0 \ |
There was a problem hiding this comment.
Thanks. I'm not have a strong opinion for it. Let's keep this in this PR.
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9640f78. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…pache#47837) ### Rationale for this change This fixes the Meson configuration ### What changes are included in this PR? Added new bpacking modules to the Meson configuration ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#47836 Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2 participants
Rationale for this change
This fixes the Meson configuration
What changes are included in this PR?
Added new bpacking modules to the Meson configuration
Are these changes tested?
Yes
Are there any user-facing changes?
No