Skip to content

GH-47836: [C++] Fix Meson configuration after bpacking changes #47837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Oct 21, 2025
Merged

GH-47836: [C++] Fix Meson configuration after bpacking changes #47837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a69971c
GH-47836: [C++] Fix Meson configuration after bpacking changes
WillAyd Oct 16, 2025
88f54f5
Allow more time for Azure tests
WillAyd Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/scripts/cpp_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ fi
if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
ARROW_BUILD_EXAMPLES=OFF # TODO: Remove this
meson test \
--max-lines=0 \
Copy link
Member

@kou kou Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this option but does this disable log output on failure?

Copy link
Contributor Author

@WillAyd WillAyd Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the test log only shows 100 lines of output. When there are many tests, the error sometimes isn't shown in the logs because it gets buffered out by other content. This makes it so the entire test log is shown on error

We made this same change in #47282, so I figured I'd just pull forwards here to reduce the diff on the other PR. Happy to drop this particular line for now

Copy link
Member

@kou kou Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm not have a strong opinion for it. Let's keep this in this PR.

--no-rebuild \
--print-errorlogs \
--suite arrow \
--timeout-multiplier=10 \
"$@"
else
ctest \
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/arrow/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ arrow_util_srcs = [
'util/bitmap_builders.cc',
'util/bitmap_ops.cc',
'util/bpacking.cc',
'util/bpacking_scalar.cc',
'util/bpacking_simd_default.cc',
'util/byte_size.cc',
'util/byte_stream_split_internal.cc',
'util/cancel.cc',
Expand Down
Loading