ARROW-7407: [Python] Declare NumPy a PEP517 build dependency #6048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Dec 17, 2019
| requires = [ | ||
| "cython >= 0.29", | ||
| "numpy==1.14.5; python_version<'3.7'", | ||
| "numpy==1.16.0; python_version>='3.7'", |
Member
There was a problem hiding this comment.
Is a precise version required? It would seem better to require a minimum version, if necessary (our use of Numpy C APIs is pretty basic, so I'm not sure it's needed).
Member
Author
There was a problem hiding this comment.
This is the minimal supported version we can build with. These are build-time only requirements. For NumPy, this means this is the lowest version that the resulting wheel is compatible with. Leaving this open would mean that the module would always be built uisng the latest numpy and then also only be usable with the latest numpy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.