Skip to content

ARROW-7407: [Python] Declare NumPy a PEP517 build dependency #6048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xhochy wants to merge 1 commit into from
Closed

ARROW-7407: [Python] Declare NumPy a PEP517 build dependency #6048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,11 @@
# under the License.

[build-system]
requires = ["setuptools", "wheel", "setuptools_scm", "cython >= 0.29"]
requires = [
"cython >= 0.29",
"numpy==1.14.5; python_version<'3.7'",
"numpy==1.16.0; python_version>='3.7'",
Copy link
Member

@pitrou pitrou Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a precise version required? It would seem better to require a minimum version, if necessary (our use of Numpy C APIs is pretty basic, so I'm not sure it's needed).

Copy link
Member Author

@xhochy xhochy Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the minimal supported version we can build with. These are build-time only requirements. For NumPy, this means this is the lowest version that the resulting wheel is compatible with. Leaving this open would mean that the module would always be built uisng the latest numpy and then also only be usable with the latest numpy.

Copy link
Member

@pitrou pitrou Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you.

"setuptools",
"setuptools_scm",
"wheel"
]