Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Apr 7, 2020

There were a number of APIs left.

@github-actions
Copy link

github-actions bot commented Apr 8, 2020

@wesm
Copy link
Member Author

wesm commented Apr 8, 2020

Please don't merge since this conflicts with #6804

@wesm wesm force-pushed the result-review-ipc-apis branch from e0e7678 to 94710b3 Compare April 8, 2020 02:59
@pitrou
Copy link
Member

pitrou commented Apr 8, 2020

Looks like there are problems:


* checking whether package ‘arrow’ can be installed ... WARNING
Found the following significant warnings:
  /arrow/cpp/src/arrow/ipc/message.cc:123:1: warning: control reaches end of non-void function [-Wreturn-type]
/arrow/cpp/src/jni/orc/jni_wrapper.cpp: In function ‘_jbyteArray* Java_org_apache_arrow_adapter_orc_OrcStripeReaderJniWrapper_getSchema(JNIEnv*, jclass, jlong)’:
/arrow/cpp/src/jni/orc/jni_wrapper.cpp:231:87: error: ‘arrow::Status arrow::ipc::SerializeSchema(const arrow::Schema&, arrow::ipc::DictionaryMemo*, arrow::MemoryPool*, std::shared_ptr<arrow::Buffer>*)’ is deprecated: Deprecated in 0.17.0. Use Result-returning version [-Werror=deprecated-declarations]
       arrow::ipc::SerializeSchema(*schema, nullptr, arrow::default_memory_pool(), &out);
                                                                                       ^
In file included from /arrow/cpp/src/arrow/ipc/api.h:25:0,
                 from /arrow/cpp/src/jni/orc/jni_wrapper.cpp:26:
/arrow/cpp/src/arrow/ipc/writer.h:437:8: note: declared here
 Status SerializeSchema(const Schema& schema, DictionaryMemo* dictionary_memo,
        ^~~~~~~~~~~~~~~

@wesm
Copy link
Member Author

wesm commented Apr 8, 2020

Will fix. I used clang to build the R bindings so I missed some deprecation warnings (wonder if there's a way to get ARROW_DEPRECATED to warn in clang?)

This will need to get rebased after ARROW-8311

@pitrou
Copy link
Member

pitrou commented Apr 9, 2020

Rebasing.

@pitrou pitrou force-pushed the result-review-ipc-apis branch from 1b922c7 to 1c27905 Compare April 9, 2020 13:01
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge if CI green.

@bkietz
Copy link
Member

bkietz commented Apr 9, 2020

@pitrou
Copy link
Member

pitrou commented Apr 9, 2020

AppVeyor build in progress:
https://ci.appveyor.com/project/pitrou/arrow/builds/32069395

@wesm
Copy link
Member Author

wesm commented Apr 9, 2020

Thanks. This is going to cause some mayhem with ARROW-8311 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants