ARROW-9284: [Java] fix getMinorTypeForArrowType with dense unions #7599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymurr
approved these changes
Jun 30, 2020
Contributor
rymurr
left a comment
rymurr
left a comment
There was a problem hiding this comment.
You beat me to it! https://github.com/apache/arrow/pull/7290/files#diff-2be1b706e7360a9277f320b59176ce6eR812
+1 from me
Member
Author
Ah, I just noticed it when I went to test Arrow master internally, should have figured you would have run into it too 😅 |
Member
Author
|
When the format changes get through, we can just land your PR and fix all this once and for all. |
Member
Author
|
Superseded by ARROW-1692/#7290. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new minor type but didn't adjust the type -> minor type mapping.