Skip to content

Conversation

@pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jun 22, 2017

An alternative would be to patch dlmalloc similarly to https://github.com/greg7mdp/dlmalloc

@pcmoritz pcmoritz changed the title ARROW-1139: Silence dlmalloc warnings on clang-4.0 ARROW-1139: Silence dlmalloc warning on clang-4.0 Jun 22, 2017
@cpcloud
Copy link
Contributor

cpcloud commented Jun 23, 2017

@pcmoritz @wesm

I just pulled this down and built plasma and successfully ran all the tests.

+1 here, thanks for doing this!

couple of things:

  • It might be nice to eventually get rid of the warnings (though it looks like this source might be out of our control).
  • There are some *_generated.h files laying around after the build, @pcmoritz can you add a .gitignore file to the src/plasma/format directory?
  • cmake throws a warning about flatbuffers_ep. we should allow users to build plasma with flatbuffers code in $FLATBUFFERS_HOME. I can follow up with a patch to do that.

@wesm
Copy link
Member

wesm commented Jun 23, 2017

I'm going to merge and leave these items to follow up patches (I also noticed the _generated.h files)

@asfgit asfgit closed this in 6768f52 Jun 23, 2017
@pcmoritz
Copy link
Contributor Author

Thanks for testing this! I created a JIRA for .gitignore here and will make a patch: https://issues.apache.org/jira/browse/ARROW-1146

I'm not as sure what is involved with flatbuffers_ep, @cpcloud if you know what is the right way to do this it might be faster if you submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants