Skip to content

ARROW-1139: Silence dlmalloc warning on clang-4.0 #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcmoritz wants to merge 3 commits into from
Closed

ARROW-1139: Silence dlmalloc warning on clang-4.0 #769

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd91ccd
silence dlmalloc warnings on clang-4.0
pcmoritz Jun 22, 2017
672ec2e
fix on g++
pcmoritz Jun 22, 2017
6602c7f
clean up
pcmoritz Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/src/plasma/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ endif()

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")

set_source_files_properties(thirdparty/dlmalloc.c PROPERTIES COMPILE_FLAGS -Wno-all)
set_source_files_properties(extension.cc PROPERTIES COMPILE_FLAGS -Wno-strict-aliasing)

set(PLASMA_SRCS
Expand All @@ -91,7 +90,7 @@ ADD_ARROW_LIB(plasma

# The optimization flag -O3 is suggested by dlmalloc.c, which is #included in
# malloc.cc; we set it here regardless of whether we do a debug or release build.
set_source_files_properties(malloc.cc PROPERTIES COMPILE_FLAGS "-Wno-error=conversion -O3")
set_source_files_properties(malloc.cc PROPERTIES COMPILE_FLAGS "-Wno-error -O3")

add_executable(plasma_store store.cc)
target_link_libraries(plasma_store plasma_static)
Expand Down