Skip to content

ARROW-9704: [Java] TestEndianness.testLittleEndian supports little- and big-endian platforms #7942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kiszk wants to merge 1 commit into from
Closed

ARROW-9704: [Java] TestEndianness.testLittleEndian supports little- and big-endian platforms #7942

kiszk wants to merge 1 commit into from

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Aug 12, 2020 •
edited
Loading

This PR aims to take care of data layout on little- and big-endian platforms in TestEndianness.testLittleEndian

@github-actions
Copy link

github-actions bot commented Aug 12, 2020

https://issues.apache.org/jira/browse/ARROW-9704

@nealrichardson
Copy link
Member

nealrichardson commented Oct 6, 2020

Is this mergeable now? According to the mailing list discussion:

It does not seem too invasive to support native endianness in
implementation libraries. As long as there is appropriate performance
testing and CI infrastructure to demonstrate the changes work.

If I read this PR correctly, it's just changing the test to follow native endianness.

@kiszk
Copy link
Member Author

kiszk commented Oct 6, 2020

Thank you for your comment.

According to Micah 's comment, we may wait until he will update the document soon.
@emkornfield WDYT?

Since Java CI was merged, I rebased to run Java CI.

@emkornfield
Copy link
Contributor

emkornfield commented Oct 7, 2020

Opened #8374 to make sure we are all on the same page, once that goes in, I think we can submit this.

@kiszk kiszk force-pushed the ARROW-9704 branch 2 times, most recently from b807bd0 to bcd756d Compare October 30, 2020 04:45
@kiszk
Copy link
Member Author

kiszk commented Oct 30, 2020

@nealrichardson @emkornfield Is it ok to merge this? I think that this failure is not related to the change of this PR.

@nealrichardson
Copy link
Member

nealrichardson commented Oct 30, 2020

Sounds like it. I'll merge.

@asfimport asfimport mentioned this pull request Oct 30, 2020
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@kiszk @kou
ARROW-9704: [Java] TestEndianness.testLittleEndian supports little- a…
06506a2 
…nd big-endian platforms

This PR aims to take care of data layout on little- and big-endian platforms in `TestEndianness.testLittleEndian`

Closes apache#7942 from kiszk/ARROW-9704

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiszk @nealrichardson @emkornfield