Skip to content

Conversation

@emkornfield
Copy link
Contributor

@kiszk @jacques-n @wesm @pitrou @BryanCutler @nealrichardson this capture my understanding of the mailing list conversation on endianness. Please let me know if I've mischaracterized anything (I'll do a proof reading/compiling round once as long as the general points are agreed upon).

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: While there is no PR to implement cross platform support for Java, I will submit the PR later after supporting the level 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jacques-n was against cross-platform support in Java?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Before the asking review for the PR, I will gather the consensus on the ML.

@pitrou pitrou changed the title ARROW-10203: Give guidance on big-endian support in the contributors … ARROW-10203: Give guidance on big-endian support in the contributors docs Oct 7, 2020
@kszucs kszucs changed the title ARROW-10203: Give guidance on big-endian support in the contributors docs ARROW-10203: [Doc] Give guidance on big-endian support in the contributors docs Oct 9, 2020
@emkornfield emkornfield force-pushed the update_contributor_guidelines branch from aae6c43 to 27d6273 Compare October 16, 2020 05:52
@emkornfield
Copy link
Contributor Author

I'm having trouble getting the source build environment setup on my machine to verify correct layout, I'll try again tomorrow. Let me know if there are other comments otherwise I think we can merge this and go ahead and start incorporating the other PRs for endianness.

+++++++++
The Arrow format allows setting endianness. Due to the popularity of little endian
architectures most of implementation assume little endian by default. There has been some
effort to support big endian platforms as well. Based on a mailing list discussion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to link some JIRAs either here or below?

``deserialize_components`` is also available as a method on
``SerializationContext`` objects.

Serializing pandas Objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove this to build the docs. This is a deprecated functionality.

@pitrou
Copy link
Member

pitrou commented Oct 19, 2020

+1, will merge.

@pitrou pitrou closed this in 0230c9d Oct 19, 2020
kszucs pushed a commit that referenced this pull request Oct 19, 2020
…utors docs

@kiszk @jacques-n @wesm @pitrou @BryanCutler @nealrichardson  this capture my understanding of the mailing list conversation on endianness.  Please let me know if I've mischaracterized anything (I'll do a proof reading/compiling round once as long as the general points are agreed upon).

Closes #8374 from emkornfield/update_contributor_guidelines

Lead-authored-by: Micah Kornfield <emkornfield@gmail.com>
Co-authored-by: emkornfield <micahk@google.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants