ARROW-11439: [Rust] Add year support to temporal kernels #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
approved these changes
Feb 1, 2021
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
LGTM, there's a clippy lint and a minor nit.
alamb
approved these changes
Feb 2, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
looks good to me - thanks @Dandandan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds year support to the temporal module. Year support is something needed for some TCPH queries.
Together with
extractsupport#9359
we should be able to add
EXTRACT (YEAR FROM dt)support to DataFusion.Other changes in the PR:
hourvalue_as_datetimeandvalue_as_time) but I leave that for a future PR, as well as further performance improvements (e.g. avoiding theInt32Builder, avoiding null checks, adding some microbenchmarks etc.).