-
Notifications
You must be signed in to change notification settings - Fork 45
Update XMLBeans #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XMLBeans #894
Conversation
Bumps org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0. --- updated-dependencies: - dependency-name: org.apache.xmlbeans:xmlbeans dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
- xmlbeans no longer supports the GENERATE_JAVA_VERSION attribute, i.e. the constant still exists but is not referenced and there is no way to set it with the new API
|
@cortlepp thanks for merging this - I meant to review this for a while now, and it fell thru the cracks. The impact is kind of big with 30+ files changed - we'll see how the community adapts, as I no longer use it myself. XMLBeans has a unique history as an Apache project - it is the only project ever that was sent to the purgatory of the "attic". It was rescued by Apache Poi, and it jumped from v3 to v5. That's part of the reason the merge request dragged on - it's a complicated project. Thanks again for sticking with this. |
|
@robertlazarski I didn't merge this yet, just converted the PR back to draft because it had non-trivial failing tests (something to do with a now unsupported/not enabled XML feature in our JS engine). I still want to look into this, but I wanted to clean up the open PRs list as this is clearly not ready to be merged. |
|
@cortlepp @robertlazarski Let me add to my voice to the chorus. I've just stumbled upon this PR, and can't wait to see it merged. We're facing some dependency hell with xmlbeans being pinned to old 3.0.0 by Axis2, and it's blocking us from using other libraries that rely on new xmlbeans 5.3.0. This PR solves our issue smoothly. |
|
@lgayard-brex Do you use the scripting module though (i.e. the part of axis2 that uses xmlbeans)? Because that is pretty surely broken in this branch right now, and still needs to be fixed. Any help would be greatly appreciated there (especially, but necessarily, if you use the scripting module. I never have and it is therefore somewhat hard to "fix" things when you don't really know how it is supposed to work). If you care about this being merged, I'd encourage you to look into fixing the current (integration)test failures that occur in the scripting module in this branch. I only looked into it superficially for now, in scripting we also still depend on an outdated version of the rhino JS engine and some other things, but I don't know yet how all of these dependencies work together. Even just getting a better picture of how things are working now, before the update, would really help. Otherwise I suspect that this will still take some time. This is currently not a priority for me and I also can't yet tell how much work is still needed to complete this. |
@cortlepp @robertlazarski Please find my PR at #980 , which could replace this; it also bumps Rhino to a more recent version as part of the fix, and fixes the broken test. |
|
Superseded by #980. |
No description provided.