Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0; rhino to 1.8.0 #980
Conversation
- Update JSOMElementConvertor to handle XMLBeans 5.3.0 API changes - Add fallback mechanisms for getXmlObject() method removal - Implement string-based XML parsing as ultimate fallback - Normalize XML whitespace to fix test assertions - Maintain backward compatibility with older XMLBeans versions
|
Hey, thank you for looking into this! It seems like some code in |
modules/scripting/src/org/apache/axis2/scripting/convertors/JSOMElementConvertor.java
Outdated
Show resolved
Hide resolved
- xmlbeans no longer supports the GENERATE_JAVA_VERSION attribute, i.e. the constant still exists but is not referenced and there is no way to set it with the new API
I just noticed that I had already fixed at least some of those errors in my PR. I pushed them now (i hope you don't mind), we'll see if CI passes now. |
Thank you for that. Hopefully, we're closer to getting this PR merged. |
…MLString Removes field scope from class JSOMElementConvertor. This field was created within an enter/exit block in the constructor, but after the exit block, its state was invalid. Reduces try/catch scope when parsing xml object.
cortlepp
left a comment
cortlepp
left a comment
There was a problem hiding this comment.
To me this looks good, but because I don't have any experience with / knowledge of xmlbeans all I can really do is a formal review(besides making sure that the tests pass).Since this library hasn't been updated in a while, and the API is not exactly foolproof to use, I'd guess that the chance of breaking things is quite high (but doing the update is unavoidable).
@robertlazarski from your point of view is there anything left to do here before we can merge this?
|
@cortlepp I no longer use XMLBeans at my day job as we use JSON with Axis2 now - anyways, in the early days of Axis2 I wrote some of the XMLBean docs and I know enough to test it via those docs as a basic sanity check. Go ahead and merge it - I will do some basic tests after that. |
|
@cortlepp thanks for merging. Can you hint at the release schedule? When can we expect a version to hit the Maven repos? |
|
No later than end of year we hope - we need another release to do a Rampart 2.0.0. Top priority for now is Axis2/C since the Apache board of directors - they monitor all 300+ projects - has that project on their radar due to a long time without a release. |
|
@robertlazarski is there something else that you want to get into the next release? Or is it just the release process/vote etc. that will take some time? |
|
@cortlepp thanks for asking. I'm super busy at my day job at the moment though my time should be freeing up for Axis soon. See this link for the open issues tagged for 2.0.1, feel free to work on any of them. |
|
Gentle bump on this ticket @cortlepp @robertlazarski |
|
We are all volunteers at Apache and it is nearly impossible to give an accurate ETA. Speaking for myself, I have day job pressure to support openjdk 21 and http/2 asap, the former is completed and the latter is now in progress. I think January is realistic, give or take a few weeks. |
3 participants
Bump org.apache.xmlbeans:xmlbeans from 3.0.1 to 5.3.0
Bump org.mozilla:rhino to 1.8.0, as fix to scripting module
Fix scripting module compatibility with XMLBeans 5.3.0