Fix Python lint commands in contribution guide #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint_py2 and lint_py3 are no longer defined in the tox.ini config file. When I try the currently suggested commands, I get the following error message: ERROR: unknown environment 'lint_py2' py27-lint and py3-lint appear to be the replacements.
angoenka
approved these changes
Apr 4, 2018
|
Thanks for fixing this. |
|
@committer Can you please merge this. |
Member
|
CC: @melap |
|
We have a broken link unrelated to this PR that will not allow merging until it's fixed, I will merge this as soon as that's merged. (#413) |
Member
|
#412 replaces the |
|
ok, does that obsolete this PR then? |
Member
|
Yes, IMO. |
Author
|
agreed, this seems obsolete. (I just tested the gradlew command and it worked!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint_py2 and lint_py3 are no longer defined in the tox.ini config file. When
I try the currently suggested commands, I get the following error message:
ERROR: unknown environment 'lint_py2'
py27-lint and py3-lint appear to be the replacements.