Update instructions to run linter. #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to tox.ini were done in apache/beam#4877.
Author
|
R: @udim |
|
sorry, removed in #412 (not 415) |
Author
|
Thanks, looks like with #412 this change is no longer needed. |
Author
|
On the other hand since 3 different people were wasting cycles on this during last week, we might as well fix it while #412 is crystalizing, assuming it as simple as running asfgit merge or something similar. |
melap
approved these changes
Apr 11, 2018
|
A fair point, I will merge this |
|
@asfgit merge |
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
melap
pushed a commit
to apache/beam
that referenced
this pull request
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to tox.ini were done in apache/beam#4877.