Increase overhaed budget for test_sampler_transition_overhead #10012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is flaky when it is run under load. Increasing overhead budget as a temporary fix. A better solution would be to change the test structure to not depend on specific timings.
Contributor
|
LGTM. If the test is inherently flaky, we can also add a tenacity retry decorator. |
Member
Author
Done. Good idea, thank you. |
tvalentyn
reviewed
Nov 6, 2019
| overhead_us = 1000000.0 * elapsed_time / state_transition_count | ||
|
|
||
| # TODO: This test is flaky when it is run under load. A better solution | ||
| # would be to change the test structure to not depend on specific timings. |
Contributor
There was a problem hiding this comment.
Please copy or move this comment to line 98.
tvalentyn
approved these changes
Nov 6, 2019
Member
Author
|
Run Portable_Python PreCommit |
Member
Author
|
Run Python PreCommit |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky when it is run under load. Increasing overhead budget as a temporary fix.
A better solution would be to change the test structure to not depend on specific timings.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.