Skip to content

Increase overhaed budget for test_sampler_transition_overhead #10012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltay merged 3 commits into from
Nov 8, 2019
Merged

Increase overhaed budget for test_sampler_transition_overhead #10012

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b043c9
Increase overhaed budget for test_sampler_transition_overhead
aaltay Nov 6, 2019
5688a31
Add tenacity retry decorator
aaltay Nov 6, 2019
e5ccedc
fixup
aaltay Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sdks/python/apache_beam/runners/worker/statesampler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ def test_basic_sampler(self):
self.assertGreater(actual_value, expected_value * (1.0 - margin_of_error))
self.assertLess(actual_value, expected_value * (1.0 + margin_of_error))

# TODO: This test is flaky when it is run under load. A better solution
# would be to change the test structure to not depend on specific timings.
@retry(reraise=True, stop=stop_after_attempt(3))
def test_sampler_transition_overhead(self):
# Set up state sampler.
counter_factory = CounterFactory()
Expand All @@ -117,6 +120,11 @@ def test_sampler_transition_overhead(self):
elapsed_time = time.time() - start_time
state_transition_count = sampler.get_info().transition_count
overhead_us = 1000000.0 * elapsed_time / state_transition_count

# TODO: This test is flaky when it is run under load. A better solution
# would be to change the test structure to not depend on specific timings.
Copy link
Contributor

@tvalentyn tvalentyn Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy or move this comment to line 98.

overhead_us = 2 * overhead_us

logging.info('Overhead per transition: %fus', overhead_us)
# Conservative upper bound on overhead in microseconds (we expect this to
# take 0.17us when compiled in opt mode or 0.48 us when compiled with in
Expand Down