Skip to content

[BEAM-8335] Modify the TestStreamPayload to accept an argument of output_tags and… #10826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukecwik merged 1 commit into from
Feb 13, 2020
Merged

[BEAM-8335] Modify the TestStreamPayload to accept an argument of output_tags and… #10826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions model/interactive/src/main/proto/beam_interactive_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,6 @@ message TestStreamFileHeader {
// give enough information to create a faithful recreation of the original
// stream of data.
message TestStreamFileRecord {
oneof recorded_event {
// The recorded element with its event timestamp (when it was produced).
org.apache.beam.model.pipeline.v1.TestStreamPayload.TimestampedElement element = 1;

// Indicating the output watermark of the source changed.
google.protobuf.Timestamp watermark = 2;
}

// The wall-time timestamp of either the new element or watermark change.
google.protobuf.Timestamp processing_time = 3;
// The recorded event from an element stream.
org.apache.beam.model.pipeline.v1.TestStreamPayload.Event recorded_event = 1;
}
9 changes: 8 additions & 1 deletion model/pipeline/src/main/proto/beam_runner_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,14 @@ service TestStreamService {
// A TestStream will request for events using this RPC.
rpc Events(EventsRequest) returns (stream TestStreamPayload.Event) {}
}
message EventsRequest {}

message EventsRequest {
// The set of PCollections to read from. These are the PTransform outputs
// local names. These are a subset of the TestStream's outputs. This allows
// Interactive Beam to cache many PCollections from a pipeline then replay a
// subset of them.
repeated string output_ids = 1;
}

// The payload for the special-but-not-primitive WriteFiles transform.
message WriteFilesPayload {
Expand Down