[BEAM-8335] Modify the TestStreamPayload to accept an argument of output_tags and… #10826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @davidyan74 |
rohdesamuel
force-pushed
the
rohdesamuel_master/merge
branch
from
c578c30 to
571c49e
Compare
Contributor
|
LGTM |
davidyan74
approved these changes
Feb 11, 2020
lukecwik
reviewed
Feb 11, 2020
Contributor
Author
|
R: @pabloem Hey Pablo, can you please review this? |
rohdesamuel
force-pushed
the
rohdesamuel_master/merge
branch
from
571c49e to
2b6c043
Compare
lukecwik
reviewed
Feb 12, 2020
Change-Id: I84ec1dd4698534c26c3a5219669da5f1a127250a
rohdesamuel
force-pushed
the
rohdesamuel_master/merge
branch
from
2b6c043 to
6fee530
Compare
lukecwik
approved these changes
Feb 13, 2020
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… modify the TestStreamFileRecord to use TestStreamPayload events.
Change-Id: I84ec1dd4698534c26c3a5219669da5f1a127250a
Adds the output_tags in the TestStreamPayload for allowing converting a TestStream to/from proto without reading from its events.
Also adds a file format version for the TestStreamFileHeader to document which version for backwards compatibility when decoding.
Also adds a list of "keys" to request which PCollection to read from in the TestStreamService.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.