[BEAM-8335] Update StreamingCache with new Protos #10856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id7afe89f21221e7fa98ef9066805549493005bc9
Contributor
Author
|
R: @davidyan74 |
Member
|
retest this please |
davidyan74
approved these changes
Feb 13, 2020
Contributor
|
Looks like you need to run yapf? https://cwiki.apache.org/confluence/display/BEAM/Python+Tips |
Change-Id: I8c92ab9bc98e1885a29f756ea8021c7fd2f3ee8a
Contributor
Author
|
retest this please |
1 similar comment
Member
|
retest this please |
lukecwik
approved these changes
Feb 14, 2020
Member
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
LGTM, assuming tests pass
Thanks for the quick turnaround.
| if record.HasField('processing_time_event'): | ||
| self._stream_times[tag] += timestamp.Duration( | ||
| micros=record.processing_time_event.advance_duration) | ||
| records.append((tag, record, self._stream_times[tag])) |
Member
There was a problem hiding this comment.
this would be much more readable if we used typing.NamedTuple
4 tasks
Member
|
retest this please |
Member
|
For the failing pre-commit, I filed:
|
Member
|
Since this is a known break to python. Will merge now and please perform any clean-up in a follow-up PR. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the breakage from #10826.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.