[BEAM-9317] Fix portable test executions to specify the beam_fn_api argument #10867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
Run Java Flink PortableValidatesRunner Batch |
Member
Author
|
Run Java Flink PortableValidatesRunner Streaming |
Member
Author
|
Run Java Spark PortableValidatesRunner Batch |
...-java/src/main/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuser.java
Outdated
Show resolved
Hide resolved
…rgument This allows for SDK level overrides when executing portable pipelines to occur.
lukecwik
force-pushed
the
splittabledofn4
branch
from
e3e536b to
42717e9
Compare
Member
Author
|
Run Java Flink PortableValidatesRunner Batch |
Member
Author
|
Run Java Flink PortableValidatesRunner Streaming |
Member
Author
|
Run Java Spark PortableValidatesRunner Batch |
TheNeuralBit
approved these changes
Feb 14, 2020
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
LGTM assuming PVR tests pass
Member
Author
|
Run Java Spark PortableValidatesRunner Batch |
Member
Author
|
The Python failures are known to exist and are being fixed in #10856 |
Member
Author
|
The PVR tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for SDK level overrides when executing portable pipelines to occur.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.