[BEAM-9821] Populate all SpannerIO batching parameters in display data. #11528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2020
Contributor
Author
|
retest this please |
Contributor
|
LGTM. Thanks. |
allenpradeep
approved these changes
May 6, 2020
TheNeuralBit
approved these changes
May 14, 2020
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
LGTM aside from some minor questions
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
Outdated
Show resolved
Hide resolved
Member
|
Retest this please |
Add all the grouping/batching parameters in SpannerIO populateDisplayData().
Contributor
Author
|
Retest this please |
2 similar comments
Member
|
Retest this please |
Member
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the batching/grouping parameters are added in populateDisplayData() for SpannerIO.Write, and there is no populateDisplayData in SpannerIO.WriteGrouped.
This PR adds all the grouping/batching parameters to both
SpannerIO.Write.populateDisplayData()SpannerIO.WriteGrouped.populateDisplayData()Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.