[BEAM-9822] Simplify pipeline when batching is disabled. #11529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielm
force-pushed
the
skipBatchingIfDisabled
branch
3 times, most recently
from
f133b40 to
5d7dda4
Compare
nielm
force-pushed
the
skipBatchingIfDisabled
branch
from
5d7dda4 to
4031659
Compare
allenpradeep
approved these changes
May 6, 2020
nielm
force-pushed
the
skipBatchingIfDisabled
branch
2 times, most recently
from
2955973 to
718884b
Compare
Member
|
Retest this please |
Grouping adds significant latency and memory use, and when streaming this causes both OOMs and high pipeline latencies.
When batching is disabled, there is no need for SpannerIO to read the schema, group, sort, batch and write batches, so simplify the pipeline to just write the mutation.
nielm
force-pushed
the
skipBatchingIfDisabled
branch
from
718884b to
ade11d9
Compare
Contributor
Author
|
Retest this please |
Member
|
Retest this please |
TheNeuralBit
requested changes
May 19, 2020
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Mostly LGTM, just one minor request
...ogle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOWriteTest.java
Show resolved
Hide resolved
Contributor
Author
|
Retest this please |
1 similar comment
Member
|
Retest this please |
TheNeuralBit
approved these changes
May 20, 2020
Member
|
LGTM. I'll merge when CI is green |
Member
|
Retest this please |
3 similar comments
Member
|
Retest this please |
Member
|
Retest this please |
Member
|
Retest this please |
Member
|
Jenkins seems to be very sleepy today... |
Member
|
Retest this please |
Member
|
retest this please |
Member
|
Retest this please |
1 similar comment
Member
|
Retest this please |
Member
|
Run Java PostCommit |
1 similar comment
Member
|
Run Java PostCommit |
Member
|
Run Java PreCommit |
1 similar comment
Member
|
Run Java PreCommit |
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
* Disable grouping by default when streaming. Grouping adds significant latency and memory use, and when streaming this causes both OOMs and high pipeline latencies. * Simplify pipeline when batching is disabled. When batching is disabled, there is no need for SpannerIO to read the schema, group, sort, batch and write batches, so simplify the pipeline to just write the mutation. * Fix noBatching test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching is often disabled in streaming pipelines to improve latency. When this is the case, there is no
point in adding several transforms to group/sort/batch the elements, so if batching is disabled, a simple pipeline is used.
Note, this PR is dependent on PR #11528 and PR #11532
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.