Skip to content

Conversation

@ettirapp
Copy link
Contributor

These are WordCount integration test for Azure filesystem. Before merging, the input file needs to be changed to either use the Azurite emulator for Azure or to use a file in an Azure storage account that belongs to Beam.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests

See CI.md for more information about GitHub Actions CI.

ettirapp and others added 25 commits August 16, 2020 18:17
removed ignored test from this PR

removed unused file

fixed a typo

small fixes

small fixes

small fixes

small fixes for readability

cleaning code

small fixes

ignore mockito config, move test file

implemented an azure blob storage filesystem

removed ignored test from this PR

removed unused file

fixed a typo

small fixes

small fixes

small fixes

small fixes for readability

cleaning code

small fixes

ignore mockito config, move test file

implemented an azure blob storage filesystem

removed ignored test from this PR

removed unused file

fixed a typo

small fixes

small fixes

small fixes

small fixes for readability

cleaning code

small fixes

ignore mockito config, move test file

organized dependencies

fixed a typo
applied spotless to fix formatting
…blobstore/AzureBlobStoreFileSystem.java

Co-authored-by: Pablo <pabloem@users.noreply.github.com>
@ettirapp ettirapp changed the title [BEAM-10378] Integration tests to run against Azure service or emulator [BEAM-10378] Integration tests for Azure filesystem Aug 20, 2020
@ettirapp
Copy link
Contributor Author

R: @pabloem

@ettirapp ettirapp changed the title [BEAM-10378] Integration tests for Azure filesystem [BEAM-10778] Integration tests for Azure filesystem Aug 20, 2020
@ettirapp
Copy link
Contributor Author

Run Java PreCommit

1 similar comment
@ettirapp
Copy link
Contributor Author

Run Java PreCommit

@ettirapp
Copy link
Contributor Author

The changes that need to be made before merging this commit are the DEFAULT_INPUT in line 41 of AzureWordCountIT, and some form of authentication for the Azure account (currently a connection string) in line 63 of that file. The input file is currently https://github.com/apache/beam/blob/master/sdks/java/io/azure/src/test/resources/in.txt, if the input file is changed then the checksum should also be changed in lines 42-43.

@ettirapp
Copy link
Contributor Author

(The failing test is because no form of authentication is provided for the storage account.)

@ettirapp
Copy link
Contributor Author

Never mind - I guess it's passing :)

@pabloem pabloem self-requested a review September 8, 2020 13:56
@aaltay
Copy link
Member

aaltay commented Sep 17, 2020

@pabloem - what is the next step on this PR?

@stale
Copy link

stale bot commented Nov 26, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Nov 26, 2020
@stale
Copy link

stale bot commented Dec 13, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Dec 13, 2020
@pabloem pabloem reopened this Jan 26, 2021
@stale
Copy link

stale bot commented Jan 26, 2021

This pull request is no longer marked as stale.

@stale stale bot removed the stale label Jan 26, 2021
@pabloem
Copy link
Member

pabloem commented Jan 26, 2021

my apologies for dropping this. I'll try to get this in soon.

@pabloem
Copy link
Member

pabloem commented Jan 26, 2021

Run Java PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 8, 2022
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants