-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-10778] Integration tests for Azure filesystem #12649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
removed ignored test from this PR removed unused file fixed a typo small fixes small fixes small fixes small fixes for readability cleaning code small fixes ignore mockito config, move test file implemented an azure blob storage filesystem removed ignored test from this PR removed unused file fixed a typo small fixes small fixes small fixes small fixes for readability cleaning code small fixes ignore mockito config, move test file implemented an azure blob storage filesystem removed ignored test from this PR removed unused file fixed a typo small fixes small fixes small fixes small fixes for readability cleaning code small fixes ignore mockito config, move test file organized dependencies fixed a typo
applied spotless to fix formatting
…blobstore/AzureBlobStoreFileSystem.java Co-authored-by: Pablo <pabloem@users.noreply.github.com>
|
R: @pabloem |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
The changes that need to be made before merging this commit are the DEFAULT_INPUT in line 41 of AzureWordCountIT, and some form of authentication for the Azure account (currently a connection string) in line 63 of that file. The input file is currently https://github.com/apache/beam/blob/master/sdks/java/io/azure/src/test/resources/in.txt, if the input file is changed then the checksum should also be changed in lines 42-43. |
|
(The failing test is because no form of authentication is provided for the storage account.) |
|
Never mind - I guess it's passing :) |
|
@pabloem - what is the next step on this PR? |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
This pull request is no longer marked as stale. |
|
my apologies for dropping this. I'll try to get this in soon. |
|
Run Java PreCommit |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
These are WordCount integration test for Azure filesystem. Before merging, the input file needs to be changed to either use the Azurite emulator for Azure or to use a file in an Azure storage account that belongs to Beam.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.