[BEAM-11363] Create :sdks:java:extensions:ml:integrationTest target, run in Java PostCommit
#13444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Run Java PostCommit |
6 tasks
Member
Author
|
Run Spotless PreCommit |
TheNeuralBit
changed the title
:sdks:java:extensions:ml:integrationTest target, run in Java PostCommit:sdks:java:extensions:ml:integrationTest target, run in Java PostCommit
Member
Author
|
Run Java PostCommit |
kennknowles
reviewed
Dec 3, 2020
| ]) | ||
|
|
||
| // Disable Gradle cache: these ITs interact with live service that should always be considered "out of date" | ||
| outputs.upToDateWhen { false } |
Member
There was a problem hiding this comment.
Just want to note that "UP-TO-DATE" and "FROM-CACHE" are two different Gradle statuses for a task. I presume if it is never up to date it is also never cached...
Member
Author
There was a problem hiding this comment.
I copied this from
beam/sdks/java/extensions/google-cloud-platform-core/build.gradle
Lines 76 to 77 in c5d5b9a
I can update the comments in both places to be more correct - it sounds like just dropping "Disable Gradle cache:" would address it?
kennknowles
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running IT classes in the
:testtask, this PR runs them in a separate:integrationTesttask, which is run by the Java PostCommit.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.